Hi Denk, Thanks for comments.
Agree with you. We need to find a better way to find about board revision than the current method which depends on presence of i2c EEPROM on the board. I will drop this patch also from this series. I will device a better patch And submit later. Thanks, Nag On Tue, Aug 02, 2011 at 21:57:32, Wolfgang Denk wrote: > Dear nagabhushana.netagu...@ti.com, > > In message <1312299792-16415-9-git-send-email-nagabhushana.netagu...@ti.com> > you wrote: > > From: Manjunathappa, Prakash <prakash...@ti.com> > > > > The Spectrum Digital AM18xx EVM contains I2C EEPROM compared > > da850/omap-l138 Logic PD EVMs. ... > > Sorry, I cannot parse this. Please reformulate. > > > + /* Spectrum Digital AM18xx EVM contains I2C EEPROM compared > > + da850/omap-l138 Logic PD EVMs. This information is used to > > + differentiate the EVMs and is passed to kernel via second > > + byte of ATAG_REVISION. */ > > Incorrect multiline comment style. > > > + if (i2c_probe(0x50) == 0) > > + rev |= 0x100; > > Would it not be better to provide #defines instead of these hardwired magic > numbers (both address and mask)? > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de What > the gods would destroy they first submit to an IEEE standards committee. > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
