From: Juuso Rinta <[email protected]>

Hi Simon,

Thank you for the comments.

On 2026-07-15, Simon Glass wrote:
> Assuming this is a static value, it might be more efficient (code size
> and simplicity) to add a max_timeout_ms (max timeout in milliseconds)
> uint to the per-device uclass-plat data - 0 could mean no limit, thus
> allowing existing drivers to not set it.

I agree, using a max_timeout_ms would make this patch series a bit simpler
while still fixing the issue that motivated the series in the first place.
In this case the wdt gettimeout subcommand would no longer make sense
so I could also drop that. That's fine though, as the print we get from
calling wdt_start() is the more important thing here, the subcommand was
more of a by-product of the approach I had.

I will work out a v2 where drivers set their timeout value to the per-device
plat data during probe time, and wdt_start() considers max_timeout_ms value
of 0 as "limitless" or basically that the feature is not supported, in which
case we stick to the current approach. I'll build and run a few tests. v2 to
be delivered this week.

Best regards,
Juuso

Reply via email to