Hi Peng and Fabio,

It looks like this may have been lost in review. Peng replied to the series 
about some topics in the cover letter, but not requesting any changes to the 
patches. I assume as a result it was marked as "Changes Requested" in 
Patchwork.[1]

Fabio, it looks the patches were delegated to you in Patchwork. I'm not sure if 
there's anything else you need to do.

Best,
Philip

[1]: 
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

On Friday, March 6th, 2026 at 9:58 AM, Philip Molloy <[email protected]> 
wrote:

> This series makes minor clean-up changes to the i.MX DDR init code.
> 
> Unfortunately, I don't have access to any NXP hardware. I ran into LTO
> issues with my Fedora toolchain building imx8mm_evk_defconfig. And
> binman issues because of missing binary blobs with some imx9*
> defconfigs. But compilation was successful.
> 
> To support an upcoming ADI SoC that also uses LPDDR4 and Synpsys IP I
> would like to leverage the i.MX implementation. Therefore this clean-up
> can also serve as a kind of pre-RFC. I would love to know if the
> maintainers are open to transitioning to a more generic implementation.
> If so, I'll submit a proper RFC. I'll also be at Embedded World next
> week if anyone would like to discuss in person.
> 
> Some additional context and a comparison of DDR init implementations:
> 
> https://philipmolloy.com/ddr-init.html
> 
> I reviewed the NXP i.MX downstream repo on Github.[1] The changes in
> this series are not fixed downstream. The only major difference with
> downtream for the PHY driver appears to be "Quickboot" support, which is
> specific to the i.MX 95.
> 
> [1]: https://github.com/nxp-imx/uboot-imx
> 
> Philip Molloy (4):
>   ddr: imx: Remove duplicate includes
>   ddr: imx: Remove undefined declarations
>   ddr: imx: Remove unused macros
>   ddr: imx: Remove unnecessary macro argument
> 
>  arch/arm/include/asm/arch-imx8m/ddr.h | 10 ++++------
>  arch/arm/include/asm/arch-imx9/ddr.h  |  8 ++------
>  drivers/ddr/imx/imx8m/ddr_init.c      |  8 ++++----
>  drivers/ddr/imx/phy/ddrphy_utils.c    | 15 +++++++--------
>  drivers/ddr/imx/phy/helper.c          |  4 +---
>  5 files changed, 18 insertions(+), 27 deletions(-)
> 
> -- 
> 2.53.0
> 
> base-commit: 7995bf8dea2d5b3eb7fcb836636f4773924ec35d
> branch: ddr-imx-clean-up
>

Reply via email to