On 7/13/2026 4:24 PM, Simon Glass wrote: > Hi Jonas, > > On 2026-07-08T22:05:26, Jonas Karlman <[email protected]> wrote: >> Kconfig: Add missing depends on xPL to xPL_ symbols >> >> xPL_<name> symbols should typically depend on the associated xPL symbol. >> >> Add missing depends on xPL to xPL_<name> symbols to avoid the xPL_<name> >> symbols being available when the associated xPL symbol is disabled. >> >> Signed-off-by: Jonas Karlman <[email protected]> >> >> common/Kconfig | 2 ++ >> lib/Kconfig | 7 ++++++- >> 2 files changed, 8 insertions(+), 1 deletion(-) > >> diff --git a/lib/Kconfig b/lib/Kconfig >> @@ -972,23 +973,27 @@ config SPL_LZO >> config TPL_GZIP >> - bool "Enable gzip decompression support for SPL build" >> + bool "Enable gzip decompression support for TPL build" >> + depends on TPL > > The prompt fix is separate from adding the dependencies, so please can > you mention it in the commit message? Otherwise it looks like a stray > hunk.
Sure, will update commit message in v2. > >> diff --git a/lib/Kconfig b/lib/Kconfig >> @@ -960,6 +960,7 @@ config TPL_LZMA >> config VPL_LZMA >> bool "Enable LZMA decompression support for VPL build" >> + depends on VPL > > BTW SPL_LZMA_SIZE_OPTIMIZATION (between SPL_LZMA and TPL_LZMA) has no > dependency at all, so it shows up in menuconfig even without SPL. It > fits the pattern this patch fixes and could get 'depends on SPL_LZMA' > while you are here. What do you think? Thanks, I have already added following for v2 of this patch: - SPL_SYS_L2_PL310 - SPL_SYS_STDIO_DEREGISTER - SPL_NVMEM And a new patch that adds depends on [xPL_]LZMA to [xPL_]LZMA_SIZE_OPTIMIZATION symbols, I felt it was different enough to put such change in a dedicated patch. Will send the v2 once the I2C_LEGACY size change is resolved/accepted. Regards, Jonas > > Reviewed-by: Simon Glass <[email protected]> > > Regards, > Simon
