According to Tom's remarks
- Improve the help structure and content.
- Mark functions as static.
- Remove documentation of exported functions
- As asked, addded a kernel doc to:
ufshcd_query_desc_idn_geometry, ufshcd_query_desc_idn_config,
ufshcd_query_desc_idn_device, ufshcd_query_desc_idn_unit,
ufshcd_print_idn_geometry_desc, ufshcd_print_device_descriptor
ufshcd_print_unit_descriptor, ufshcd_query_desc_idn_power
ufshcd_print_ufs_power_params, ufshcd_query_user_flag
- Add command get_lun
- Add command clear_lun
- Add command provision
- Removed float use in the code, it breaks arm compilation.
- Add wmb. wmb is not implemented in x86, brakes the UFS compilation in
x86.
- Test: ./tools/buildman/buildman mips64el arm x86_64 -a UFS -a CMD_UFS -a SCSI
-a CMDLINE
Passed 94 boards, but consumed too much time and could not continue.
- I stil fail to run on gitab ci, My adminitratos do not know how to
help me, i have no runners.
- github does not work as well, no runners. I do not have Azure acount.
- Link to v4:
https://patch.msgid.link/[email protected]
Changes in v4:
Apply Tom's remarks.
- move exported functions from drivers/ufs/ufs.h to include/ufs.h
- document the above exported functions in kernel-doc style.
- Fix commit title: "extend the current command line..."
- rework rst file, verified the html version.
- Run pull request in CI.
- Link to v3:
https://patch.msgid.link/[email protected]
Changes in v3:
- remove set_dev_desc command. DeviceDescriptor is not writable
- Beautify the rst document
- Link to v2:
https://patch.msgid.link/[email protected]
ufs: Exted cmd line
The UFS command provides utilities for querying, displaying, and modifying
UFS device configuration and descriptor information. It is commonly used to
configure UFS logical units (LUNs) in U-Boot, allowing storage devices to be
provisioned and reconfigured as needed.
Features:
* Display Device, Geometry, Unit, Configuration, and Power Descriptors
* Display LUN configuration and calculated capacities
* Modify fields in Device, Configuration, and Unit Descriptors
* Query common UFS runtime flags
* Commit configuration changes or clear all LUN configurations
* Decode and format descriptor contents for easier debugging
* Provision and configure UFS logical units
Changes in v2:
* Add HBA ID support
* Move ufs_tool.c to cmd/ufs.c
* Add myself as reviewer
* Rename patch subject to "ufs: document the UFS command"
To: [email protected]
Cc: Neil Armstrong <[email protected]>
Cc: Bhupesh Sharma <[email protected]>
Cc: Neha Malcom Francis <[email protected]>
Cc: Tawfik Bayouk <[email protected]>
Cc: Vladimir Kondratiev <[email protected]>
Signed-off-by: Raz Ben Yehuda <[email protected]>
---
Raz Ben Yehuda (5):
MAINTAINERS: Add myself to the list of UFS maintainers
ufs: Expose selected UFS functions
ufs: document the UFS command
ufs: extend the current command-line interface
ufs: wmb is not implemented in x86.
MAINTAINERS | 3 +
arch/x86/include/asm/io.h | 2 +
cmd/ufs.c | 1612 ++++++++++++++++++++++++++++++++++++++++++++-
doc/usage/cmd/ufs.rst | 499 ++++++++++++++
drivers/ufs/ufs-uclass.c | 18 +-
drivers/ufs/ufs.h | 52 --
include/ufs.h | 421 ++++++++++++
7 files changed, 2536 insertions(+), 71 deletions(-)
---
base-commit: 0c035ff60c1e8caee7fccd2673ce75380dee825b
change-id: 20260607-ufs_tool2-11c3493690c4
Best regards,
--
Raz Ben Yehuda <[email protected]>
