Hi Nora, On 2026-05-26T12:40:39, Feilke, Alexander <[email protected]> wrote: > board: tq: common: add sysinfo helpers > > Add a number of helpers based on the tq_eeprom sysinfo driver and > related hardware detection features. The helpers set up the U-Boot > environment and fixup the OS Device Tree. > > Signed-off-by: Nora Schiffer <[email protected]> > Signed-off-by: Alexander Feilke <[email protected]> > > board/tq/common/Kconfig | 6 ++++++ > board/tq/common/Makefile | 1 + > board/tq/common/tq_sysinfo.c | 32 ++++++++++++++++++++++++++++++++ > board/tq/common/tq_sysinfo.h | 15 +++++++++++++++ > 4 files changed, 54 insertions(+)
Reviewed-by: Simon Glass <[email protected]> > diff --git a/board/tq/common/Kconfig b/board/tq/common/Kconfig > +config TQ_COMMON_SYSINFO > + bool > + select SYSINFO > + imply SYSINFO_TQ_EEPROM > + depends on !SPL_BUILD SPL_BUILD is a compile-time macro, not a Kconfig symbol - I believe it silently evaluates to true. You could use 'depends on !SPL' (see env/Kconfig) but given the Makefile already gates the object with CONFIG_$(PHASE_)TQ_COMMON_SYSINFO, this can just be dropped. > diff --git a/board/tq/common/tq_sysinfo.c b/board/tq/common/tq_sysinfo.c > +/* > + * Common sysinfo helpers for TQ-Systems SOMs The commit message says 'The helpers set up the U-Boot environment and fixup the OS Device Tree' but this patch only adds a single helper that touches env, with no DT fixup code. Please bring the commit message in line with the patch (and drop 'a number of helpers' - there is just one), or move the DT-fixup helper into this patch if it was meant to be here. Regards, Simon
