> GD25Q256 ia 256Mb flash device with Quad interface at max 80MHz clock rate. ia -> is
The datasheet says it's up-to 133MHz. If you tested at 80MHz, please mention that. > This flash supports 2.7-3.6V voltage range. > > Tested on MediaTek's filogic platform. > > Link: https://download.gigadevice.com/Datasheet/DS-00526-GD25Q256E-Rev1.3.pdf > > Signed-off-by: Weijie Gao <[email protected]> Please remove blank line between the tags. > --- > v3: removed locking flags. updated commit message > v2: updated commit message > --- > drivers/mtd/spi/spi-nor-ids.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c > index fcc546fb5ae..9271cefc759 100644 > --- a/drivers/mtd/spi/spi-nor-ids.c > +++ b/drivers/mtd/spi/spi-nor-ids.c > @@ -147,6 +147,10 @@ const struct flash_info spi_nor_ids[] = { > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > }, > + { > + INFO("gd25q256", 0xc84019, 0, 64 * 1024, 512, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) > + }, Same ID but different name entry below (I overlooked this in previous review). Both 'Q' and 'B' are available in GigaDevice website. What's the difference? > /* adding these 3V QSPI flash parts */ > {INFO("gd25b256", 0xc84019, 0, 64 * 1024, 512, SECT_4K | > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | > SPI_NOR_4B_OPCODES) }, Thanks, Takahiro
