On Wed, May 06, 2026 at 03:14:11PM +0200, Quentin Schulz wrote: > Hi Lukas, > > On 5/6/26 1:13 AM, Lukas Timmermann wrote: > > This patch series adds the necessary files to use a modern pinctrl driver > > with an exynos5250 SoC. The changes are well tested and are working. > > > > In contrast to v1, this reenables GPIO functionality. But as I'm still > > lacking experience, I'm not quite sure on how to prevent s5p_gpio to > > load when using upstream DTS in a clean way. Because of that, this > > patch series is marked as an RFC. > > checkpatch complains about using #ifdef. > > > > We already have an issue with samsung,exynos78x0-gpio so we'd need a similar > work-around for that one. > > An easy way to sort this out would be to know if we know of devices which > are still using the old binding? Qualcomm is rather special, is Samsung > Exynos also special with regard to how it handles Device Trees? Do we get it > from an earlier boot stage or is everything coming from U-Boot itself? If > the latter, we can always migrate the existing devices to the new binding > and remove support for the old binding and with it the same compatible in > two drivers. Another question would be, does it make sense for both drivers > to be compiled? If not (e.g. it's only pinctrl IPs inside an SoC and there's > only one pinctrl device per SoC, so if your device supports the new binding, > you only need the new driver). Then we can add a > depends on !PINCTRL_EXYNOS5250 > for CONFIG_S5P (we probably should have a different symbol for the GPIO > driver though, maybe CONFIG_GPIO_S5P?). > > Cheers, > Quentin
I'm sorry. Some of these Infos should've been in my original message: This driver replaces the pinctrl functionality in the old s5p_gpio driver. It doesn't replace GPIO functionality itself. So both drivers have to be compiled in order to work with modern upstream DTs. This driver binds the older s5p_gpio driver during its own binding. The pinctrl dt-bindings are incompatible to each other. This driver fixes pinctrl with upstream DTs and the older one must be used on it's own when relying on U-Boots deprecated DTs. DTs are provided by U-Boot itself, at least that's the case on my device (exynos5250-manta). If I understood you correctly, we could modify the deprecated exynos5250.dtsi to fix this situation. But I don't know about possible side effects and I'm not that experienced in kernel/bootloader development. Is this an option? I had split the gpio symbol into it's own thing before and could add that back into v4 but it's functionally the same. (Both drivers needed for upstream DT) Best regards, Lukas
