----- "Prafulla Wadaskar" <prafu...@marvell.com> wrote:

> > -----Original Message-----
> > From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com]
> > Sent: Monday, July 18, 2011 3:12 PM
> > To: Prafulla Wadaskar
> > Cc: u-boot@lists.denx.de; Ajay Bhargav
> > Subject: [PATCH 4/4] Armada100: Enable Ethernet support for GplugD
> 
> BTW: This should be third patch, PHY support should be after FEC
> support.
> 

Can't we merge PHY and FEC together? 'coz without setting up PHY, FEC cannot
work properly. They are kind of connected.

> > 
> > This patch enables ethernet support for Marvell GplugD board.
> Network
> > related commands works.
> > 
> > Signed-off-by: Ajay Bhargav <ajay.bhar...@einfochips.com>
> > ---
> >  arch/arm/include/asm/arch-armada100/armada100.h |   57
> > +++++++++++++++++++++++
> >  arch/arm/include/asm/arch-armada100/mfp.h       |   19 ++++++++
> >  board/Marvell/gplugd/gplugd.c                   |   38
> +++++++++++++++
> >  include/configs/gplugd.h                        |   19 +++++++-
> >  4 files changed, 131 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/include/asm/arch-armada100/armada100.h
> > b/arch/arm/include/asm/arch-armada100/armada100.h
> > index 3d567eb..849638d 100644
> > --- a/arch/arm/include/asm/arch-armada100/armada100.h
> > +++ b/arch/arm/include/asm/arch-armada100/armada100.h
> > @@ -41,6 +41,10 @@
> >  /* Functional Clock Selection Mask */
> >  #define APBC_FNCLKSEL(x)        (((x) & 0xf) << 4)
> > 
> > +/* Fast Ethernet Controller Clock register definition */
> > +#define FE_CLK_RST                0x1
> > +#define FE_CLK_ENA                0x8
> 
> Modifying armada100.h is not a part of board support patch, pls
> abstract and put it in separate patch
> 

Okay.. will do that.

Regards,
Ajay Bhargav
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to