On Mon, 2026-03-02 at 18:03 -0600, David Lechner wrote:
> Move repeated *_PARENT() macros from chip-specific .c files to the
> common mtk-clk.h file.
> 
> Signed-off-by: David Lechner <[email protected]>
> ---
>  drivers/clk/mediatek/clk-mt7622.c | 8 --------
>  drivers/clk/mediatek/clk-mt7623.c | 6 ------
>  drivers/clk/mediatek/clk-mt7629.c | 4 ----
>  drivers/clk/mediatek/clk-mt7981.c | 5 -----
>  drivers/clk/mediatek/clk-mt7986.c | 5 -----
>  drivers/clk/mediatek/clk-mt7987.c | 4 ----
>  drivers/clk/mediatek/clk-mt7988.c | 4 ----
>  drivers/clk/mediatek/clk-mt8189.c | 4 ----
>  drivers/clk/mediatek/clk-mtk.h    | 7 +++++++
>  9 files changed, 7 insertions(+), 40 deletions(-)
> 
> 
> [snip...]
> 
> diff --git a/drivers/clk/mediatek/clk-mt8189.c
> b/drivers/clk/mediatek/clk-mt8189.c
> index 4ade03f2f6c..744e644f138 100644
> --- a/drivers/clk/mediatek/clk-mt8189.c
> +++ b/drivers/clk/mediatek/clk-mt8189.c
> @@ -429,10 +429,6 @@ static const struct mtk_fixed_factor
> top_fixed_divs[] = {
>       FACTOR1(CLK_TOP_OSC_D20, CLK_PAD_ULPOSC, 1, 20),
>  };
>  
> -#define EXT_PARENT(id) PARENT(id, CLK_PARENT_EXT)
> -#define APMIXED_PARENT(id) PARENT(id, CLK_PARENT_APMIXED)
> -#define TOP_PARENT(id) PARENT(id, CLK_PARENT_TOPCKGEN)
> -
>  static const struct mtk_parent axi_parents[] = {
>       EXT_PARENT(CLK_PAD_CLK26M),
>       TOP_PARENT(CLK_TOP_MAINPLL_D4_D4),
> diff --git a/drivers/clk/mediatek/clk-mtk.h
> b/drivers/clk/mediatek/clk-mtk.h
> index 8374ed5ce78..588c940b715 100644
> --- a/drivers/clk/mediatek/clk-mtk.h
> +++ b/drivers/clk/mediatek/clk-mtk.h
> @@ -122,6 +122,13 @@ struct mtk_parent {
>               .flags = _flags,                        \
>       }
>  
> +#define APMIXED_PARENT(id)   PARENT(id, CLK_PARENT_APMIXED)
> +#define TOP_PARENT(id)               PARENT(id, CLK_PARENT_TOPCKGEN)
> +#define INFRA_PARENT(id)     PARENT(id, CLK_PARENT_INFRASYS)
> +#define XTAL_PARENT(id)              PARENT(id, CLK_PARENT_XTAL)
> +#define EXT_PARENT(id)               PARENT(id, CLK_PARENT_EXT)
> +#define VOID_PARENT          PARENT(-1, 0)
> +
>  /**
>   * struct mtk_composite - aggregate clock of mux, divider and gate
> clocks
>   *
> 

Reviewed-by: Macpaul Lin <[email protected]>

Thanks!
Macpaul Lin

Reply via email to