On Wed Jan 28, 2026 at 10:05 AM EET, Wojciech Dubowik wrote:
> Only short option has been present. Also rename dump_sig
> to dump-sig to match with other parameter names.
>
> Fixes: 16abff246b40 ("tools: mkeficapsule: add firmware image signing")
>
> Signed-off-by: Wojciech Dubowik <[email protected]>
> ---Reviewed-by: Ilias Apalodimas <[email protected]> > doc/mkeficapsule.1 | 4 ++-- > tools/binman/btool/mkeficapsule.py | 2 +- > tools/mkeficapsule.c | 3 ++- > 3 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/doc/mkeficapsule.1 b/doc/mkeficapsule.1 > index a726149ba2ce..d6653ec42472 100644 > --- a/doc/mkeficapsule.1 > +++ b/doc/mkeficapsule.1 > @@ -121,8 +121,8 @@ Specify a monotonic count which is set to be > monotonically incremented > at every firmware update. > > .TP > -.B "-d\fR,\fB --dump_sig" > -Dump signature data into *.p7 file > +.B "-d\fR,\fB --dump-sig" > +Dump signature data into <capsule-file-name>.p7 file > > .SH "GUIDGEN OPTIONS" > > diff --git a/tools/binman/btool/mkeficapsule.py > b/tools/binman/btool/mkeficapsule.py > index f7e5a8868495..f2ac654db81e 100644 > --- a/tools/binman/btool/mkeficapsule.py > +++ b/tools/binman/btool/mkeficapsule.py > @@ -16,7 +16,7 @@ Options: > -p, --private-key <privkey file> private key file > -c, --certificate <cert file> signer's certificate file > -m, --monotonic-count <count> monotonic count > - -d, --dump_sig dump signature (*.p7) > + -d, --dump-sig dump signature to <output file>.p7 > -A, --fw-accept firmware accept capsule, requires GUID, no image blob > -R, --fw-revert firmware revert capsule, takes no GUID, no image blob > -o, --capoemflag Capsule OEM Flag, an integer between 0x0000 and 0xffff > diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c > index a61557b73bef..e9b9ffe9b774 100644 > --- a/tools/mkeficapsule.c > +++ b/tools/mkeficapsule.c > @@ -56,6 +56,7 @@ static struct option options[] = { > {"fw-revert", no_argument, NULL, 'R'}, > {"capoemflag", required_argument, NULL, 'o'}, > {"dump-capsule", no_argument, NULL, 'D'}, > + {"dump-sig", no_argument, NULL, 'd'}, > {"help", no_argument, NULL, 'h'}, > {NULL, 0, NULL, 0}, > }; > @@ -83,7 +84,7 @@ static void print_usage_mkeficapsule(void) > "\t-p, --private-key <privkey file> private key file\n" > "\t-c, --certificate <cert file> signer's certificate > file\n" > "\t-m, --monotonic-count <count> monotonic count\n" > - "\t-d, --dump_sig dump signature (*.p7)\n" > + "\t-d, --dump-sig dump signature to <output > file>.p7\n" > "\t-A, --fw-accept firmware accept capsule, requires GUID, no > image blob\n" > "\t-R, --fw-revert firmware revert capsule, takes no GUID, no > image blob\n" > "\t-o, --capoemflag Capsule OEM Flag, an integer between 0x0000 > and 0xffff\n"
