Hi Peter, On 12/9/25 10:18 PM, Peter Robinson wrote:
Upstream device tree has rules where the aliases are board specific settings, no SoC settings. Looking at upstream rk356x boards there's a lot of variation in the setting of mmc0/mmc1 based on the device so we should not be overriding this here and now we sync to upstream we should just consume those settings, to do otherwise confuses users.
Do all boards with DM_SEQ_ALIAS config set have these aliases set? Otherwise the MMC device index may change between reboots.
While this change is appropriate, we should care to not break users just for the sake of being correct. The easiest check could be to build all rk356* DTB before and after your patch and see if it changes something and for those boards whose DTB changed, whether they use DM_SEQ_ALIAS in some U-Boot phase or not.
Cheers, Quentin
