On Tue, 2025-12-09 at 10:24 +0100, Julien Stephan wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Le ven. 5 déc. 2025 à 11:53, Macpaul Lin (林智斌) > <[email protected]> a écrit : > > > > On Wed, 2025-12-03 at 10:31 +0100, Julien Stephan wrote: > > > > > > External email : Please do not click links or open attachments > > > until > > > you have verified the sender or the content. > > > > > > > > > From: Julien Masson <[email protected]> > > > > > > This adds basic support for MediaTek MT8188 SoC. > > > > > > Add watchdog support by adding upstream compatible string. > > > > > > Add tphy support by adding "mediatek,generic-tphy-v2" compatible > > > string > > > in arch/arm/dts/mt8188-u-boot.dtsi > > > > > > Signed-off-by: Julien Masson <[email protected]> > > > Signed-off-by: Julien Stephan <[email protected]> > > > --- > > > MAINTAINERS | 1 + > > > arch/arm/dts/mt8188-u-boot.dtsi | 10 +++++ > > > > Where is mt8188.dtsi? > > Would you please to keep the mt8188.dtsi > > and then create the seperate mt8188-u-boot.dtsi? > > Please refer to other platforms like mt7622 or mt7982, etc. > > > > Hi Macpaul, > > mt8188.dtsi is located in > dts/upstream/src/arm64/mediatek/mt8188.dtsi > mt8188-u-boot.dtsi is applied on top of this device tree. > If I am correct new submissions should use the Linux Kernel upstream > dts located in dts/upstream (config OF_UPSTREAM). > I think other platforms like mt7622 or mt7982 needs to be switched to > config OF_UPSTREAM.
Got it. The previous reply is because I've not seen the defconfig of this board here. Hence I'm not sure if you'd like to use config OF_UPSTREAM. I'll treat the following patches apply the same policy by default. > > > > arch/arm/mach-mediatek/Kconfig | 11 +++++- > > > arch/arm/mach-mediatek/Makefile | 1 + > > > arch/arm/mach-mediatek/mt8188/Makefile | 3 ++ > > > arch/arm/mach-mediatek/mt8188/init.c | 69 > > > ++++++++++++++++++++++++++++++++++ > > > drivers/watchdog/mtk_wdt.c | 1 + > > > 7 files changed, 95 insertions(+), 1 deletion(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index > > > b43dae882b3ea33c2cd745bd3759e3f4d97abc80..5b52d2fe17506d2659be901 > > > 6a7c > > > a639062332ae9 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -415,6 +415,7 @@ M: Chunfeng Yun <[email protected]> > > > M: Igor Belwon <[email protected]> > > > R: GSS_MTK_Uboot_upstream > > > <[email protected]> > > > S: Maintained > > > +F: arch/arm/dts/mt* > > > F: arch/arm/mach-mediatek/ > > > F: arch/arm/include/asm/arch-mediatek/ > > > F: board/mediatek/ > > > > > > > > > [snip] > > > > Thanks for helping upstream these SOC to u-boot upstream. > > However, I've found it seems lots of formatting issues (errors > > and warnings) in coding style when I ran checkpatch through > > these patches. > > > > Please help to fix them as could as possible. > > > > > diff --git a/arch/arm/dts/mt8188-u-boot.dtsi > > > b/arch/arm/dts/mt8188-u- > > > boot.dtsi > > > new file mode 100644 > > > index > > > 0000000000000000000000000000000000000000..6d1b2ab82da1c95a49b8a69 > > > 3eb0 > > > f854ab913a26b > > > --- /dev/null > > > +++ b/arch/arm/dts/mt8188-u-boot.dtsi > > > > [snip] > > > > > > > diff --git a/arch/arm/mach-mediatek/mt8188/init.c > > > b/arch/arm/mach- > > > mediatek/mt8188/init.c > > > new file mode 100644 > > > index > > > 0000000000000000000000000000000000000000..3389c03b06006e8130b4ce4 > > > 48d5 > > > dcfb8f103c28f > > > --- /dev/null > > > +++ b/arch/arm/mach-mediatek/mt8188/init.c > > > @@ -0,0 +1,69 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (C) 2025 MediaTek Inc. > > > + * Copyright (C) 2025 BayLibre, SAS > > > + * Author: Julien Masson <[email protected]> > > > + */ > > > > > > Would you please help to keep the origin author here together with > > you? > > Since this file should come from > > > > > > https://urldefense.com/v3/__https://gitlab.com/mediatek/aiot/bsp/u-boot/-/blob/mtk-v2022.10/arch/arm/mach-mediatek/mt8188/init.c?ref_type=heads__;!!CTRNKA9wMg0ARbw!g1jvseoe-aWfRI03AOhWdeIzjL71HFhalyAq4Id4QxJfntBDi45wMkpcTnaaCt_qnbhHboj_nV_TytCcOH1Zww$ > > Author: Chris-QJ Chen <[email protected]> > > > > you are right, I forgot to add back Chris-QJ Chen, I'll do it, thank > you for the reminder! > > Cheers > Julien Stephan > > > And please help to do it so when you adding back mt8188.dtsi. > > > > Thanks! > > Macpaul Lin > > Best regards, Macpaul Lin
