On 15:52-20251208, Andrew Goodbody wrote: > > > On 08/12/2025 15:38, Tom Rini wrote: > > On Mon, Dec 08, 2025 at 09:32:26AM -0600, Nishanth Menon wrote: > > > On 08:10-20251206, Tom Rini wrote: > > > > On Fri, 21 Nov 2025 17:34:30 +0000, Andrew Goodbody wrote: > > > > > > > > > Smatch reported an error where a value calculated by ERR_PTR was not > > > > > used. Fixing this to return the generated value led to a test failure > > > > > which meant updating the sandbox clock code so that it would still > > > > > cause > > > > > the tests to pass with the above correction. > > > > > Debugging this problem led to a SIGSEGV which is addressed in 1/3. > > > > > Possible memory leaks noticed are addressed in 3/3. > > > > > > > > > > [...] > > > > > > > > Applied to u-boot/next, thanks! > > > > > > > > [1/3] clk: Prevent SIGSEGV on debug > > > > commit: 1c0a46e2918a1ddf42f51449e45077513dd52417 > > > > [2/3] clk: Return value calculated by ERR_PTR > > > > commit: fe780310cfa8bf5a093894b5cd7fe85c6b02fd91 > > > > > > This commit seems to have broken TI platforms in next branch. > > > > > > u-boot$ git bisect log > > > git bisect start > > > # status: waiting for both good and bad commits > > > # bad: [bc1819331ece7aa4e7d0573c9cdacdb8efbdb067] Merge patch series > > > "clk: Return value calculated by ERR_PTR" > > > git bisect bad bc1819331ece7aa4e7d0573c9cdacdb8efbdb067 > > > # status: waiting for good commit(s), bad commit known > > > # good: [384d3785df4dbe452f9fbb4bd9c9c9e986cdc205] Merge patch series > > > "led: remove unused legacy LED code" > > > git bisect good 384d3785df4dbe452f9fbb4bd9c9c9e986cdc205 > > > # good: [1e8eff6d7a9ad2c605185e5b3d8c22ccd26733dc] board: ti: > > > CAT24C256WI-GT3 require min. 5ms delay (tWR) between write/read > > > git bisect good 1e8eff6d7a9ad2c605185e5b3d8c22ccd26733dc > > > # good: [1165e8efcba0ab3efd1ea4ff956d26746fc386b0] reboot-mode: Correct > > > macro name from U_BOOT_DEVICE to U_BOOT_DRVINFO > > > git bisect good 1165e8efcba0ab3efd1ea4ff956d26746fc386b0 > > > # bad: [fe780310cfa8bf5a093894b5cd7fe85c6b02fd91] clk: Return value > > > calculated by ERR_PTR > > > git bisect bad fe780310cfa8bf5a093894b5cd7fe85c6b02fd91 > > > # good: [1c0a46e2918a1ddf42f51449e45077513dd52417] clk: Prevent SIGSEGV > > > on debug > > > git bisect good 1c0a46e2918a1ddf42f51449e45077513dd52417 > > > # first bad commit: [fe780310cfa8bf5a093894b5cd7fe85c6b02fd91] clk: > > > Return value calculated by ERR_PTR > > > > > > Confirmed by reverting the commit. Looks like > > > 9ed8fafbcde3425d8817ec5953edd428c7508153 revert is needed again? > > > > Interesting, OK. What Andrew did in commit > > fe780310cfa8bf5a093894b5cd7fe85c6b02fd91 is more complex than before and > > there's two stanzas there. Our lab is current being re-worked again > > right now so I can't test on the K3 platforms I have, but can you please > > see which of the two changes in clk-uclass.c is the one that breaks > > these platforms? Thanks! > What is the breakage please? I did put this series through CI and the only > issues were due to lack of disk space, so not related to the patches. > > Andrew > Looks like A72 would'nt get started.. adding a bit of print to get an idea:
https://gist.github.com/nmenon/c0487b99cbd2308ccd11ffe510a780bb -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D https://ti.com/opensource
