On Mon, Dec 01, 2025 at 04:02:07PM -0300, Fabio Estevam wrote: > On Thu, Nov 27, 2025 at 6:55 AM Joseph Guo <[email protected]> wrote: > > > +config TARGET_IMX91_11X11_FRDM > > + bool "imx91_11x11_frdm" > > + select OF_BOARD_FIXUP > > + select IMX91 > > + imply BOOTSTD_FULL > > + imply BOOTSTD_BOOTCOMMAND > > What is the plan to convert this board to OF_UPSTREAM? > > Has the DTS already been submitted upstream? Please include the lore > link of the submission. Sure, will add in next version.
> > > +config IMX91_FRDM_LPDDR4 > > + bool "Using LPDDR4 Timing and PMIC voltage" > > + default y > > + select IMX9_LPDDR4X > > + help > > + Select the LPDDR4 timing and 1.1V VDDQ > > There is no need for this IMX91_FRDM_LPDDR4 symbol. Please drop it. > > It would make sense if there was a DDR4 version too. > Noted > > +F: configs/imx91_11x11_frdm_defconfig > > +F: configs/imx91_11x11_frdm_inline_ecc_defconfig > > Why do we need two defconfigs for this board? > > What are the pros and cons of using one versus the other? > > Can't we simply use a single one? > > If you really need both, then please avoid duplication by adding > including a common include to both. ECC is to detect and correct errors in data of the ddr. It is needed. I will add a common include to reduce duplicate code. Regards, Joseph
