Assign the return value of snprintf (total length) to a variable to properly check if the string has the correct length.
Currently, this variable is always zero and the length check after snprintf will always fail. Signed-off-by: Daniel Schultz <[email protected]> --- No changes between v1 and v2. board/phytec/common/phytec_som_detection.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/phytec/common/phytec_som_detection.c b/board/phytec/common/phytec_som_detection.c index 136f4486eb0..ff1711c24b4 100644 --- a/board/phytec/common/phytec_som_detection.c +++ b/board/phytec/common/phytec_som_detection.c @@ -346,8 +346,8 @@ static int phytec_get_part_number(struct phytec_eeprom_data *data, return 0; } if (api2->som_type <= 3) { - snprintf(part, PHYTEC_PART_NUMBER_MAX_LEN + 1, "%s.%s", - product_name, api2->bom_rev); + len = snprintf(part, PHYTEC_PART_NUMBER_MAX_LEN + 1, "%s.%s", + product_name, api2->bom_rev); if (len != PHYTEC_PART_NUMBER_KSP_LEN) return -EINVAL; return 0; -- 2.25.1
