Thanks for your comment, Peng.
On 11/18/2025 10:39 AM, Peng Fan wrote:
On Mon, Nov 10, 2025 at 09:37:30AM -0800, Tanmay Kathpalia wrote:
Add reset control functionality to the SDHCI Cadence driver to properly
handle hardware reset sequences during probe. This ensures the controller
is in a known state before initialization.
Signed-off-by: Tanmay Kathpalia <[email protected]>
Reviewed-by: Balsundar Ponnusamy <[email protected]>
---
drivers/mmc/sdhci-cadence.c | 8 ++++++++
1 file changed, 8 insertions(+)
....
@@ -225,6 +227,12 @@ static int sdhci_cdns_probe(struct udevice *dev)
if (!plat->hrs_addr)
return -ENOMEM;
+ ret = reset_get_bulk(dev, &reset_bulk);
Should this be optional? Some in tree platforms may not have
the reset supported.
Yes, you're right-some in-tree platforms may not have reset support. In
those cases, the code will print a warning message ("Can't get reset")
and continue the probe process.
If you prefer, I can remove the warning and let the function fail
silently instead, or is there any other way you would suggest to make
this optional?
Regards
Peng
