Hi Marek,
On Sun, 16 Nov 2025 at 02:20, Marek Vasut <[email protected]> wrote: > > On 11/14/25 8:03 AM, Ilias Apalodimas wrote: > > Hello Ilias, > > >> + img = memalign(8, image_size); > >> + if (!img) > >> + return EFI_EXIT(EFI_BAD_BUFFER_SIZE); > >> + memcpy(img, image, image_size); > >> + } else { > >> + img = (void *)image; > >> + } > >> + > >> + ret = fit_update(img); > >> + > >> + if ((uintptr_t)image & 7) > >> + free(img); > > > > Initialize img to NULL and make the check a bit simpler to read (or > > get rid of it overall) > This part ^ I do not understand. The img variable is used by > fit_update(img) , where should it be initialized to NULL ? The patch might be misleading since it doesn't show the entire function. But from what I saw 'img' is only initialized when 'if ((uintptr_t)image & 7)' is true. you can initialize img to NULL on the declaration and just check for that. Cheers /Ilias
