Newer versions of libfdt strictly check whether the FDT blob passed to them is at 8-byte aligned offset, if it is not, then the library fails checks with -FDT_ERR_ALIGNMENT . Currently, android_image_print_dtb_contents() passed FDT directly mapped from abootimg to libfdt, and this FDT is not always aligned to 8-byte offset. Specifically, the FDTs are somewhat packed in the abootimg, therefore if the first FDT blob is e.g. 0xfd bytes long, then the next FDT blob ends up at 0xfd offset, which is not 8-byte aligned.
Fix this by first extracting the header into 8-byte aligned buffer, checking only the header for validity, and then by copying the entire FDT into newly allocated 8-byte aligned buffer. While this is not efficient, it is the correct way to handle DTs, which must be at 8-byte aligned offsets. Mitigate the inefficiency for the common case by checking whether the DT might be 8-byte aligned and if it is, map it directly. Signed-off-by: Marek Vasut <[email protected]> --- Cc: Aaron Kling <[email protected]> Cc: Eddie Kovsky <[email protected]> Cc: George Chan <[email protected]> Cc: Julien Masson <[email protected]> Cc: Mattijs Korpershoek <[email protected]> Cc: Nicolas Belin <[email protected]> Cc: Sam Day <[email protected]> Cc: Simon Glass <[email protected]> Cc: Tom Rini <[email protected]> Cc: [email protected] --- boot/image-android.c | 46 +++++++++++++++++++++++++++++++++----------- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/boot/image-android.c b/boot/image-android.c index e46dee0d9b3..5ff2bf664e5 100644 --- a/boot/image-android.c +++ b/boot/image-android.c @@ -721,17 +721,19 @@ bool android_image_get_dtb_by_index(ulong hdr_addr, ulong vendor_boot_img, dtb_addr = dtb_img_addr; while (dtb_addr < dtb_img_addr + dtb_img_size) { const struct fdt_header *fdt; + struct fdt_header fdth __aligned(8); u32 dtb_size; fdt = map_sysmem(dtb_addr, sizeof(*fdt)); - if (fdt_check_header(fdt) != 0) { - unmap_sysmem(fdt); + memcpy(&fdth, fdt, sizeof(*fdt)); + unmap_sysmem(fdt); + + if (fdt_check_header(&fdth) != 0) { printf("Error: Invalid FDT header for index %u\n", i); return false; } - dtb_size = fdt_totalsize(fdt); - unmap_sysmem(fdt); + dtb_size = fdt_totalsize(&fdth); if (i == index) { if (size) @@ -885,23 +887,45 @@ bool android_image_print_dtb_contents(ulong hdr_addr) dtb_addr = dtb_img_addr; while (dtb_addr < dtb_img_addr + dtb_img_size) { const struct fdt_header *fdt; + struct fdt_header *fulldt; + struct fdt_header fdth __aligned(8); u32 dtb_size; fdt = map_sysmem(dtb_addr, sizeof(*fdt)); - if (fdt_check_header(fdt) != 0) { - unmap_sysmem(fdt); + memcpy(&fdth, fdt, sizeof(*fdt)); + unmap_sysmem(fdt); + + if (fdt_check_header(&fdth) != 0) { printf("Error: Invalid FDT header for index %u\n", i); return false; } - res = android_image_print_dtb_info(fdt, i); - if (!res) { + dtb_size = fdt_totalsize(&fdth); + + /* The device tree must be at an 8-byte aligned address */ + if ((uintptr_t)fdt & 7) { + fulldt = memalign(8, dtb_size); + if (!fulldt) + return false; + + fdt = map_sysmem(dtb_addr, dtb_size); + memcpy(fulldt, fdt, dtb_size); unmap_sysmem(fdt); - return false; + } else { + fulldt = map_sysmem(dtb_addr, dtb_size); } - dtb_size = fdt_totalsize(fdt); - unmap_sysmem(fdt); + res = android_image_print_dtb_info(fulldt, i); + + /* The device tree must be at an 8-byte aligned address */ + if ((uintptr_t)fdt & 7) + free(fulldt); + else + unmap_sysmem(fulldt); + + if (!res) + return false; + dtb_addr += dtb_size; ++i; } -- 2.51.0
