On Wed, Oct 22, 2025 at 11:19:21AM +0200, Quentin Schulz wrote: > Hi Tom, > > On 10/21/25 10:25 PM, Tom Rini wrote: > [...] > > diff --git a/doc/usage/cmdline.rst b/doc/usage/cmdline.rst > > index 58240c5279cd..cb353975eb82 100644 > > --- a/doc/usage/cmdline.rst > > +++ b/doc/usage/cmdline.rst > > @@ -55,6 +55,12 @@ General rules > > command will cause "run" to terminate, i. e. the remaining > > variables are not executed. > > +#. The variable `?` will be set as the return value of any command. These > > s/These/The possible/ ?
Sure. > > + values are 0 on success, -1 on a usage related errors, i. e. invalid > > syntax > > s/a// > or > s/a/any/ > ? I'll drop 'a'. > I would also add a comma after "syntax". Is that oxford comma or no? > > Should i.e. be e.g.? c.f. https://en.wiktionary.org/wiki/i.e. > > > + and 1 on any other error. Any exceptions to this are documented by the > > + specific command, i. e. :doc:`cmd/for` sets this based on the last > > command > > s/i. e./e.g./ Maybe? In both cases I'm following the example in the previous rule here that's quoted for context. -- Tom
signature.asc
Description: PGP signature
