Dear Rob Herring,
In message <1309275583-11763-1-git-send-email-robherri...@gmail.com> you wrote:
> From: Rob Herring <rob.herr...@calxeda.com>
>
> This series enables non-PCI AHCI controllers and adds support for Calxeda
> Highbank platform which uses the AHCI changes.
>
> Changes from v3:
> - Added Highbank to MAINTAINERS
> - Added back patch to fix CONFIG_SKIP_LOWLEVEL_INIT (mistakenly dropped
> from v2)
>
> Wolfgang, Albert,
>
> Can you apply these to your trees for v2011.09? All review comments have been
> addressed.
I have to admit that I dislike the way you are working.
If I'm not wrong, there have been several versions of your patches
around, but you repost again and again without any indication that
these are reposts, nor what exactly has been changed between versions.
For example, I see three different posts here:
06/11 Rob Herring [U-Boot] [PATCH 8/8] ARM: Add Calxeda Highbank platform
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101435
06/21 Rob Herring [U-Boot] [PATCH 1/5] ARM: Add Calxeda Highbank platform
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101867
06/28 Rob Herring [U-Boot] [PATCH 2/6] ARM: Add Calxeda Highbank platform
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/102124
None of these adheres to the requirements as documented here:
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
Please be aware that NOT documentaing what you changed means that all
(potential) reviewers of your code have to spend additional time
figuring out what you might have changed, and checking back in the
history if you really implemented all earlier review comments.
Speaking for me, I must state that being notoriously short of time I
am not willing to waste additional time on such postings, so I tend
to ignore them.
In short: please stick to the rules if you want your patches to go
into mainline.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
... bacteriological warfare ... hard to believe we were once foolish
enough to play around with that.
-- McCoy, "The Omega Glory", stardate unknown
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
