Hi Chance, Thank you for the patch.
On Tue, Aug 26, 2025 at 11:36, Chance Yang <[email protected]> wrote: > The issue was a mismatch in return value conventions between functions: > - getvar_get_part_info() expects >= 0 for success > - fb_nand_lookup() returns 0 on success, 1 on failure (from > mtdparts_init and find_dev_and_part) > > When partition didn't exist, fb_nand_lookup returned 1, but > fastboot_nand_get_part_info passed it directly to getvar_get_part_info, > which treated 1 >= 0 as success, causing has-slot to always return yes. > > Fix by converting positive return values to -ENOENT in > fastboot_nand_get_part_info to match the expected error convention. > > Signed-off-by: Chance Yang <[email protected]> Reviewed-by: Mattijs Korpershoek <[email protected]> > --- > Changes in v2: > - cover all the failure paths in fb_nand_lookup() > - Link to v1: > https://lore.kernel.org/r/[email protected] > --- > drivers/fastboot/fb_nand.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c > index > afc64fd5280717ae4041ed70268ccc01cfbb0496..6df3917e129556fef71640ebb1347c5eb86e648a > 100644 > --- a/drivers/fastboot/fb_nand.c > +++ b/drivers/fastboot/fb_nand.c > @@ -157,8 +157,13 @@ int fastboot_nand_get_part_info(const char *part_name, > struct part_info **part_info, char *response) > { > struct mtd_info *mtd = NULL; > + int ret; > + > + ret = fb_nand_lookup(part_name, &mtd, part_info, response); > + if (ret) > + return -ENOENT; > > - return fb_nand_lookup(part_name, &mtd, part_info, response); > + return ret; > } > > /** > > --- > base-commit: d1d53c252a4a746db5ebcdf0d6de3aa0feec504e > change-id: 20250708-master-b6a53395df05 > > Best regards, > -- > Chance Yang <[email protected]>
