Hi Fabio, On Thu Sep 11, 2025 at 9:43 PM CEST, Fabio Estevam wrote: > Hi Mathieu, > > Thanks for your patch. > > On Thu, Sep 11, 2025 at 10:35 AM Mathieu Dubois-Briand > <[email protected]> wrote: > >> + if (get_boot_device() == USB_BOOT) { >> + printf("Detect USB boot. Will enter fastboot mode!\n"); > > Nitpick: printf("USB boot detected. Will enter fasboot mode\n"); >
OK >> +fastboot_partition_alias_all=0:0 >> +fastboot_partition_alias_bootloader=0.1 >> +emmc_dev=0 >> +sd_dev=0 > > emmc_dev and sd_dev are both 0. Is this expected? > Erf, of course this is incorrect. Thanks for noticing this. >> +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9 >> +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152 > > To keep consistency with other i.MX development boards, please use: > > CONFIG_USB_GADGET_MANUFACTURER="FSL" > CONFIG_USB_GADGET_VENDOR_NUM=0x0525 > > As done in configs/imx8mp_evk_defconfig, for example. OK I will fix these points and send a new version soon. Thanks, Mathieu -- Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
