On Wednesday, June 29, 2011 18:32:49 Andreas Bießmann wrote:
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
>
> -const char version_string[] =
> - U_BOOT_VERSION" (" U_BOOT_DATE " - " U_BOOT_TIME ")"CONFIG_IDENT_STRING;
> +const char * const version_string = U_BOOT_VERSION_STRING;
two things:
- why the change to a pointer from an array ? it wastes a pointer
- this should be in a common file somewhere marked weak that way the people
who do it normal (everyone but ppc?) dont have to duplicate it at all, and the
people who do it oddly (ppc) can still keep doing what they're doing
const char __weak version_string[] = U_BOOT_VERSION_STRING;
> --- a/include/version.h
> +++ b/include/version.h
>
> +#define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \
> + U_BOOT_TIME ")" CONFIG_IDENT_STRING;
pretty sure that trailing semi-colon doesn't belong
-mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
