Re: [Upstream] [PATCH 2/2] board: phytec: phycore-imx93: Use CONFIG_PHYTEC_EEPROM_BUS

[Wadim Egorov]

On 8/28/25 11:20 AM, Primoz Fiser wrote:

Switch to use CONFIG_PHYTEC_EEPROM_BUS instead of the hard coded value
of 2 for the EEPROM I2C bus for both SPL and U-Boot proper. Possible
since commit 88a1816a9b4e ("board: phytec: common: Add PHYTEC_EEPROM_BUS
to Kconfig").

^ is this not a next-commit? I am not sure if the commit hash will survive.

Signed-off-by: Primoz Fiser <primoz.fi...@norik.com>

Besides that,

Reviewed-by: Wadim Egorov <w.ego...@phytec.de>

---
  board/phytec/phycore_imx93/phycore-imx93.c | 2 +-
  board/phytec/phycore_imx93/spl.c           | 2 +-
  configs/imx93-phycore_defconfig            | 1 +
  3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/board/phytec/phycore_imx93/phycore-imx93.c 
b/board/phytec/phycore_imx93/phycore-imx93.c
index fab66caf2a1c..c6a4e923b074 100644
--- a/board/phytec/phycore_imx93/phycore-imx93.c
+++ b/board/phytec/phycore_imx93/phycore-imx93.c
@@ -20,7 +20,7 @@ DECLARE_GLOBAL_DATA_PTR;

int board_init(void)

  {
-       int ret = phytec_eeprom_data_setup(NULL, 2, EEPROM_ADDR);
+       int ret = phytec_eeprom_data_setup(NULL, CONFIG_PHYTEC_EEPROM_BUS, 
EEPROM_ADDR);

if (ret)

                printf("%s: EEPROM data init failed\n", __func__);
diff --git a/board/phytec/phycore_imx93/spl.c b/board/phytec/phycore_imx93/spl.c
index beaa536c6007..7feee4bcf6fa 100644
--- a/board/phytec/phycore_imx93/spl.c
+++ b/board/phytec/phycore_imx93/spl.c
@@ -52,7 +52,7 @@ void spl_dram_init(void)
        int ret;
        enum phytec_imx93_ddr_eeprom_code ddr_opt = PHYTEC_IMX93_DDR_INVALID;

- ret = phytec_eeprom_data_setup(NULL, 2, EEPROM_ADDR);

+       ret = phytec_eeprom_data_setup(NULL, CONFIG_PHYTEC_EEPROM_BUS, 
EEPROM_ADDR);
        if (ret && !IS_ENABLED(CONFIG_PHYCORE_IMX93_RAM_TYPE_FIX))
                goto out;

diff --git a/configs/imx93-phycore_defconfig b/configs/imx93-phycore_defconfig

index 53cd28dfcba6..0acdfd2bf53c 100644
--- a/configs/imx93-phycore_defconfig
+++ b/configs/imx93-phycore_defconfig
@@ -7,6 +7,7 @@ CONFIG_SPL_LIBCOMMON_SUPPORT=y
  CONFIG_SPL_LIBGENERIC_SUPPORT=y
  CONFIG_NR_DRAM_BANKS=2
  CONFIG_PHYTEC_SOM_DETECTION=y
+CONFIG_PHYTEC_EEPROM_BUS=2
  CONFIG_ENV_SOURCE_FILE="phycore_imx93"
  CONFIG_ENV_SIZE=0x10000
  CONFIG_ENV_OFFSET=0x700000