On 8/19/25 12:54, Marek Vasut wrote:
> On 8/14/25 5:23 PM, Patrice CHOTARD wrote:
>>
>>
>> On 8/14/25 15:37, Marek Vasut wrote:
>>> On 8/14/25 2:09 PM, Patrice Chotard wrote:
>>>> Initially, only one STM32MP25 based board was available, the
>>>> stm32mp257f-ev1 board which was set by default in stm32mp25_defconfig.
>>>>
>>>> Since commit 79f3e77133bd ("Subtree merge tag 'v6.16-dts' of dts repo [1]
>>>> into dts/upstream")
>>>> we inherited of a second MP25 based board which is the stm32mp257f-dk
>>>> board.
>>>>
>>>> Enable OF_UPSTREAM_BUILD_VENDOR and set OF_UPSTREAM_VENDOR to allow all
>>>> STMicroelectronics DT compilation.
>>> If I build stm32mp25_defconfig , I can run the result on both EV1 and DK
>>> now ?
>>>
>>
>> With this patch yes
>>
>>> It seems only the EV1 DT is built into the binary, so why compile all DTs ?
>>
>> By default yes, only EV1 DT is built. that's why OF_UPSTREAM_BUILD_VENDOR is
>> needed to
>> allow all other st/*.dtb to be built.
>>
>>>
>>> $ grep TREE configs/stm32mp25_defconfig
>>> CONFIG_DEFAULT_DEVICE_TREE="st/stm32mp257f-ev1"
>>>
>>
>> Currently if you try to build U-Boot for stm32mp257f-dk board using the
>> following commands:
>>
>> make stm32mp25_defconfig
>> make DEVICE_TREE=st/stm32mp257f-dk
>
> Please introduce defconfig for each board instead of this hackage .
>
> Look at this example on how to use #include in defconfig files, it even
> supports multiple levels of config structure for deduplication purposes:
I know, but in downstream we already use only one defconfig for all our
STM32MP/13/15/25 SoCs.
It has impact on our internal build process and we prefer to keep the same for
all our SoCs family
Patrice
>
> $ git grep include configs/imx*dh*
> configs/imx6_dhcom_drc02_defconfig:#include <configs/dh_imx6.config>
> configs/imx6_dhcom_pdk2_defconfig:#include <configs/dh_imx6.config>
> configs/imx6_dhcom_picoitx_defconfig:#include <configs/dh_imx6.config>
> configs/imx8mp_dhcom_drc02_defconfig:#include <configs/imx8mp_dhsom.config>
> configs/imx8mp_dhcom_pdk2_defconfig:#include <configs/imx8mp_dhsom.config>
> configs/imx8mp_dhcom_pdk3_defconfig:#include <configs/imx8mp_dhsom.config>
> configs/imx8mp_dhcom_picoitx_defconfig:#include <configs/imx8mp_dhsom.config>
> configs/imx8mp_dhsom.config:#include <configs/imx_dhsom.config>
> configs/imx_dhsom.config:#include <configs/dhsom.config>
>
