On Mon, Jul 28, 2025 at 06:06:07PM +0800, Yixun Lan wrote: > [EXTERNAL MAIL] > > Hi Niu, > > You need to split the patch, and prepare a cover letter.. > > Have to say, generally, this patch isn't really different comparing > with current in tree bananapi-f3, so neither it is useful.. > > I personally would expect to see more drivers support for K1 SoC, > then figure out how to have more boards enabled.. > (I'd propose to not merge this patch, but if maintainer is ok with > this, then I'd have no objection)
Hi Niu and Yixun, I am OK merging the patch for new board, but as Yixun and Yao's suggestion, there are some modifications need to be made. Please follow the advice and re-spin a patchset, thanks! Best regards, Leo > > CC spacemit mailing list for more wide comments > > On 16:25 Mon 28 Jul , Niu Zhihong wrote: > > MUSE Pi Pro uses spacemit K1, > > a new generation of octa-core 64-bit RISC-V processor, > > which includes octa-core X60. > > > > Features tested on a MUSE Pi Pro 16GB: > > - SD-card boot > > - eMMC boot > this brings some confusions, as currently there is no SD/eMMC driver support > for K1, only means it's able to boot from SD/eMMC (with brom support) > > > > > Signed-off-by: Niu Zhihong <zhih...@nzhnb.com> > > --- > > arch/riscv/Kconfig | 4 ++ > > arch/riscv/dts/Makefile | 1 + > > arch/riscv/dts/k1-muse-pi-pro.dts | 27 ++++++++ > > board/spacemit/muse-pi-pro/Kconfig | 37 +++++++++++ > > board/spacemit/muse-pi-pro/MAINTAINERS | 6 ++ > > board/spacemit/muse-pi-pro/Makefile | 3 + > > board/spacemit/muse-pi-pro/board.c | 8 +++ > > configs/muse-pi-pro_defconfig | 6 ++ > > doc/board/spacemit/index.rst | 1 + > > doc/board/spacemit/muse-pi-pro.rst | 85 ++++++++++++++++++++++++++ > > include/configs/muse-pi-pro.h | 11 ++++ > > 11 files changed, 189 insertions(+) > > create mode 100644 arch/riscv/dts/k1-muse-pi-pro.dts > > create mode 100644 board/spacemit/muse-pi-pro/Kconfig > > create mode 100644 board/spacemit/muse-pi-pro/MAINTAINERS > > create mode 100644 board/spacemit/muse-pi-pro/Makefile > > create mode 100644 board/spacemit/muse-pi-pro/board.c > > create mode 100644 configs/muse-pi-pro_defconfig > > create mode 100644 doc/board/spacemit/muse-pi-pro.rst > > create mode 100644 include/configs/muse-pi-pro.h
