On Mon, Jul 28, 2025 at 11:36:53AM -0500, Andrew Davis wrote: > On 7/28/25 10:33 AM, Kumar, Udit wrote: > > > > On 7/28/2025 8:19 PM, Siddharth Vadapalli wrote: > > > Increase the PHY Auto-Negotiation timeout to 20,000 ms from the current > > > default of 4,000 ms inherited from "Kconfig" for PHY_ANEG_TIMEOUT. > > > > > > The motivation for this change is that existing devices will continue > > > working as-is (timeout is an upper bound and auto-negotiation can be > > > done earlier), while older Hardware connected to the board that might > > > occasionally take longer than 4,000 ms for the Auto-Negotiation process > > > will benefit from an increased timeout. > > > > > > Can we think of using TI_COMMON_OPTION , similar to TI_COMMON_CMD_OPTIONS > > > > Or simply change the default in Kconfig to something like: > > default 20000 if ARCH_K3 || ARCH_OMAP2PLUS || ARCH_KEYSTONE > default 4000 > > Much better than 45 patches updating each board defconfig individually. > > Side question, if this is right for TI plats, why is it not right for > all the other platforms? Should this be the new base default timeout? > I don't really think so in either case, the point of the timeout is to > switch to a fallback port or boot mode in a reasonable time, not sure > 20 seconds is reasonable.. > > (you probably don't need ~50 people in the TO/CC on this one either, not > everyone who has ever touched the defconfigs cares about PHY timeouts)
[trimmed the CC list a bit] The other part of this to me is, is this even right outside of "we have a big test board farm" ? And since this is read from the environment now (yes?) can we instead not just expect big labs to update the environment? Or no, too many of these will lack persistent environments? -- Tom
signature.asc
Description: PGP signature
