Hi Mike, thanks for your comments.
On 18.06.2011 23:03, Mike Frysinger wrote: > i think you'll need to split this up in logical sep changesets since you are > fixing different problems. Ok, will do. >> Things changed: >> - config.mk disable 'ld script not found error' in case if we are >> building tools only. > > i dont like copying & pasting the same logic in multiple places. this is how > code rots and bug fixes diverge. Agreed. How should I fix this? > considering LDSCRIPT/CONFIG_SYS_LDSCRIPT only get used by the top level > u-boot > file, and only when the system is configured, i wonder if we shouldnt just > rip > it out of config.mk and into the top level Makefile. > > let's see what Scott thinks ... I see. Let's wait for Scott's comments then. >> - tools/Makefile put common/env_embedded.o and envcrc.o to object list >> conditionally. This fixes errors during dependency generation. > > pretty sure this breaks board builds. if the only thing this fixes is a I'm sorry but I can't see how this can break the builds. Could you please be more specific? I've tried to build some boards, it actually works... > harmless warning when generating dependency files, then i say ignore it. > after all, this is how it has always worked in the past and no one really > cared. Yep, they are harmless but they are not warnings but rather scary errors actually. ;) I think it's better to fix them. Regards, Ilya. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
