[ . . . ]
> > > ignoring that for a sec, I'm a bit worried still about how this behaves on
> > > boards that don't implement this psci call, on sdm845 for example we just
> > > hang.
> > >
> > > I think psci_system_reset2() should be adjusted to time out (though I
> > > can't
> > > imagine a psci implementation that would return execution to el1 during
> > > the
> > > reset, so maybe the timeout isn't even needed?) and return an error if the
> > > reset didn't happen.
> >
> > Would checking if the system-reset2 function is implemented in PSCI and
> > handling appropriately similar to [1] be ok? Please let me know.
> >
>
> Yeah that looks good.
Have posted v4. Can you please check on sdm845 and see if it returns to u-boot
without hanging.
> > > Then qcom_psci_sysreset_request_arg() should print some useful error
> > > message
> > > ("reset2 not supported on this platform, reset to edl failed") and bubble
> > > up
> > > the error code to abort the reset entirely.
> >
> > If the function is not implemented will print a message and bubble up
> > -EPROTONOSUPPORT.
>
> Makes sense. Thanks!>
> > 1 -
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/psci/psci.c#n554
Thanks
Varada
