On Fri, Jun 06, 2025 at 08:41:40AM +0200, Jerome Forissier wrote:

> Move the implementation of the dns command under cmd/.
> 
> Signed-off-by: Jerome Forissier <jerome.foriss...@linaro.org>
> ---
> 
> Changes in v2:
> - New patch
> 
>  cmd/lwip/dns.c    | 123 ++++++++++++++++++++++++++++++++++++++++++++
>  net/lwip/Makefile |   1 -
>  net/lwip/dns.c    | 128 ----------------------------------------------
>  3 files changed, 123 insertions(+), 129 deletions(-)
>  delete mode 100644 net/lwip/dns.c

I assume this is copy/paste from the previous file to the new file.
Since I've asked for other changes, maybe if you do the move then split
cmd/net-lwip.c up git will more clearly see this as a move? I think you
you reword the commits with "Prepare to split $cmd from cmd/net-lwip.c
by moving ..." it will be sufficiently clear in the logs why there's a
short time of not strictly cmd code in cmd/lwip/. Thanks!

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to