On Wed, Jun 04, 2025 at 01:25:05PM +0200, Wojciech Dubowik wrote: > From: Manuel Traut <manuel.tr...@mt.com> > > The board is similar to "Kontron SL i.MX 8M Mini" SoM. > There are two variants. Snowflake_v2 has an external SDCard Interface. > LEIG is the same but without display and with emmc card only. > Both variants support 1GiB of main memory. > > [ bigeasy: porting and a bit of cleanup ] > > Signed-off-by: Manuel Traut <manuel.tr...@mt.com> > Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> > Reviewed-by: Frieder Schrempf <frieder.schre...@kontron.de> > Reviewed-by: Fabio Estevam <feste...@gmail.com> > Signed-off-by: Wojciech Dubowik <wojciech.dubo...@mt.com> [snip] > arch/arm/dts/imx8mm-mt-snowflake-v2.dts | 127 ++
What's the upstream status of this dts?
[snip]
> +&i2c1 {
> + status = "okay";
> + bootph-all;
> + bootph-pre-ram;
> +};
The bootph properties have been upstreamed and can go in the main dts
file. Also, you don't need both.
[snip]
> diff --git a/include/configs/snowflake_v2.h b/include/configs/snowflake_v2.h
> new file mode 100644
> index 000000000000..eccd01fc8ecd
> --- /dev/null
> +++ b/include/configs/snowflake_v2.h
> @@ -0,0 +1,117 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright (C) 2019 Kontron Electronics GmbH
> + * Copyright (C) 2020 Mettler-Toledo GmbH
> + *
> + * Configuration settings for the MT Snowflake v2 Terminal, based on Kontron
> + * "Kontron SL i.MX 8M Mini" SoM.
> + */
> +#ifndef __SNOWFLAKE_V2_IMX8M_MINI_H
> +#define __SNOWFLAKE_V2_IMX8M_MINI_H
> +
> +#include <asm/arch/imx-regs.h>
> +#include <linux/sizes.h>
> +
> +#ifdef CONFIG_XPL_BUILD
> +#include <config.h>
> +#endif
That's not allowed / valid. This file here is config.h.
> +
> +/*
> + * #######################################
> + * ### RAM ###
> + * #######################################
> + */
> +#define CFG_SYS_INIT_RAM_ADDR 0x40000000
> +#define CFG_SYS_INIT_RAM_SIZE SZ_2M
> +
> +#if defined(CONFIG_ENV_IS_IN_MMC)
> +/* Environment in eMMC, before config block at the end of 1st "boot sector"
> */
> +#endif
Please clean that up.
> +
> +#define CFG_SYS_SDRAM_BASE 0x40000000
> +
> +/* SDRAM configuration */
> +#define PHYS_SDRAM 0x40000000
> +#define PHYS_SDRAM_SIZE SZ_1G /* 1GB DDR */
> +
> +/* GUID for capsule updatable firmware image */
> +#define MT_SNOWFLAKE_V2_FIT_IMAGE_GUID \
> + EFI_GUID(0x3EEAE649, 0x202d, 0x5feb, 0xb6, 0x94, \
> + 0x2d, 0x75, 0x06, 0x52, 0xc6, 0x40)
> +
> +#ifndef CONFIG_XPL_BUILD
That's not allowed and..
> +
> +#define MEM_LAYOUT_ENV_SETTINGS \
Please move to using a plain text environment (board/foo/bar/bar.env).
Thanks.
--
Tom
signature.asc
Description: PGP signature
