On Mon, Jun 02, 2025 at 11:13:39PM +0200, Heinrich Schuchardt wrote:
> Am 21. Mai 2025 17:14:41 MESZ schrieb Jerome Forissier
> <jerome.foriss...@linaro.org>:
> >Extract the code that sets the RTC clock from sntp_handler() in
> >net/sntp.c and make it a new function net_sntp_set_rtc() in
> >net/net-common.c. This will allow re-use with NET_LWIP.
> >
> >Signed-off-by: Jerome Forissier <jerome.foriss...@linaro.org>
> >---
> >
> > include/net-common.h | 2 ++
> > net/net-common.c | 28 ++++++++++++++++++++++++++++
> > net/sntp.c | 23 +++--------------------
> > 3 files changed, 33 insertions(+), 20 deletions(-)
> >
> >diff --git a/include/net-common.h b/include/net-common.h
> >index e536968a92b..a021bf503ff 100644
> >--- a/include/net-common.h
> >+++ b/include/net-common.h
> >@@ -586,4 +586,6 @@ extern struct wget_http_info default_wget_info;
> > extern struct wget_http_info *wget_info;
> > int wget_request(ulong dst_addr, char *uri, struct wget_http_info *info);
> >
> >+void net_sntp_set_rtc(u32 seconds);
> >+
> > #endif /* __NET_COMMON_H__ */
> >diff --git a/net/net-common.c b/net/net-common.c
> >index e01b0da7d7b..30d04323d4a 100644
> >--- a/net/net-common.c
> >+++ b/net/net-common.c
> >@@ -1,5 +1,9 @@
> > // SPDX-License-Identifier: GPL-2.0
> >+
> >+#include <dm/uclass.h>
> > #include <net-common.h>
> >+#include <linux/time.h>
> >+#include <rtc.h>
> >
> > void copy_filename(char *dst, const char *src, int size)
> > {
> >@@ -25,3 +29,27 @@ int wget_request(ulong dst_addr, char *uri, struct
> >wget_http_info *info)
> > wget_info = info ? info : &default_wget_info;
> > return wget_do_request(dst_addr, uri);
> > }
> >+
> >+void net_sntp_set_rtc(u32 seconds)
> >+{
> >+ struct rtc_time tm;
> >+#ifdef CONFIG_DM_RTC
>
> Are there really RTC drivers that have not been converted to the driver
> model. If yes, shouldn't we drop these?
It looks like all RTC drivers are converted (and there's no 'RTC' config
option). I think just openpiton_riscv64_spl needs to be converted (or
just config options switched) so that SPL_RTC can go away as a symbol
and SPL_DM_RTC (and SPL_DM) is required if we need an RTC in SPL.-- Tom
signature.asc
Description: PGP signature
