My apologies, I accidentally didn't hit reply to all, please see below. ---------- Forwarded message --------- From: Greg Malysa <malysag...@gmail.com> Date: Tue, Jun 3, 2025 at 3:04 AM Subject: Re: [PATCH 03/10] docker: add ADI build-related tools to docker image To: Heinrich Schuchardt <xypron.g...@gmx.de>
Hi Heinrich, On Mon, Jun 2, 2025 at 4:11 PM Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > Am 2. Juni 2025 21:44:41 MESZ schrieb Greg Malysa <malysag...@gmail.com>: > >ADI processors require packaging with the ldr utility for bootrom > > "ADI processors" is not self explanatory. Can we add a sentence like > > "LDR files are the executable format for the Analog Devices ADSP-SCxxx > on-chip Boot ROM. Provide the ldr compiler for ARMv7 and ARMv8." Yes I can update the message with text like this for v2. > > > > >+# Build ldr tool for ADI boards and install to match expected abi name > >+RUN git clone > >https://github.com/analogdevicesinc/lnxdsp-arm-poky-linux-gnueabi-ldr.git > >/tmp/lnxdsp-arm-poky-linux-gnueabi-ldr && \ > >+ cd /tmp/lnxdsp-arm-poky-linux-gnueabi-ldr/src/ldr && \ > >+ ./configure && \ > >+ make -j $(nproc) && \ > >+ cp ldr /usr/bin/arm-linux-gnueabi-ldr && \ > >+ cp ldr /usr/bin/aarch64-linux-ldr > > In the Docker image we tend to put such tools into a directory in /opt. I will make this change as well and run through CI again on my runner. I'll wait a week or so for feedback on the rest of the series before resubmitting. Thanks for the feedback! Thanks, Greg