Hi,
On 5/30/25 22:27, Tom Rini wrote:
On Fri, May 23, 2025 at 11:11:37AM +0200, Patrick Delaunay wrote:
Fix and add documentation/tests for selection by string for known
partition type GUID introduced by bcb41dcaefac ("uuid: add
selection by string for known partition type GUID"):
- split list_guid for short name (used also for partiton
description with type parameter) and full name to display
information
- as the function are uuid_str_to_bin() / uuid_guid_get_str()
are no more under CONFIG_PARTITION_TYPE_GUID, since commit
31ce367cd100 ("lib/uuid.c: change prototype of uuid_guid_get_str()")
and commit c1528f324c60 ("lib: compile uuid_guid_get_str if
CONFIG_LIB_UUID=y") move the content of array under EFI_PARTITION
and linker will remove it is not used it (in SPL)
- Add and fix documentation for gpt command
- Add test test_gpt_write_part_type to test "type=" parameters
This first patch solves an issue for the "system" shortcut for ESP,
removed by commit d54e1004b8b1 ("lib/uuid.c: use unique name
for PARTITION_SYSTEM_GUID") but used in 2 location (at least):
1- board/samsung/e850-96/e850-96.env:10:
partitions=name=esp,start=512K,size=128M,bootable,type=system;
partitions+=name=rootfs,size=-,bootable,type=linux
2- arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c:1151
case PART_ESP:
/* EFI System Partition */
type_str = "system"
....
offset += snprintf(buf + offset,
buflen - offset,
",type=%s", type_str);
This leads to failure in CI:
https://source.denx.de/u-boot/u-boot/-/jobs/1151511
Hi, I understood problem,
it is the definition for "system" "EFI system partiton" under too
restrictif compilation flag
so the test is OK only if one flag is activated in:
- CONFIG_CMD_EFIDEBUG or
- CONFIG_EFI (for "U-Boot as UEFI application"=> "Support running U-Boot
from EFI")
but not activated for QEMU or for nomal use case,
when U-Boot is a just EFI loader with CONFIG_CMD_BOOTEFI
my error on EFI compilation flags: CONFIG_EFI <=> CONFIG_CMD_BOOTEFI
I will send a V3 with a update to solve the issue
Patrick
