On Thu, 15 May 2025 17:31:29 -0600, Tom Rini wrote:
> Hey all,
>
> This is a v3 of Simon's series[1] and depends on the series[2] I posted
> the other day that removes <env.h> from <command.h>. With this series
> done, I believe we've tackled all of the current cases of headers which
> include <env.h> without directly needing it. Much of this series is in
> fact Simon's v2 with the main differneces being:
> - Removing <env.h> from <net.h> at the end
> - Removing env_to_ip() given how little it's used rather than shuffling
> around where it's declared and un-inline'ing it. For a rarely used
> helper, this ends up being cleaner I think. Especially looking at some
> of the users (which called env_get repeatedly). If there's strong
> opinion here about using the other method[3] we can do that instead.
> - Setting aside for now how to handle CMD_ELF=y and NO_NET=y because
> today it's actually fine as we unconditionally build lib/net_utils.c
> where string_to_ip() is defined. I'm unsure if a further series is
> warranted here or not. We rely on link-time optimization to keep code
> readable too.
>
> [...]
Applied to u-boot/next, thanks!
[01/22] net: Remove env_get_ip helper() function
commit: 05f6f6e8c76c68a36125ec7a6af911ee9418bc99
[02/22] congatec: Include env.h to permit reading the environment
commit: 67a7633e04d71c61018d857f27d18e05acc5b844
[03/22] dhelectronics: Include env.h to permit reading the environment
commit: 09c9957e8808b6a3513450c802d43c9410a14368
[04/22] imx8ulp_evk: Include env.h to permit reading the environment
commit: 84a1c99055166857efabe55277f01341404e8dda
[05/22] net: Include string.h in net-legacy.h
commit: 0b9450989c195430521b01d97ba79a9b644119a6
[06/22] venice: Include env.h to permit reading the environment
commit: 600145a8e10418d26f43045f9452610e39ce6f38
[07/22] phytec: Include env.h to permit reading the environment
commit: b4135116116a318113968ce9f8f72c711d09dd28
[08/22] ronetix: Include env.h to permit reading the environment
commit: 6e898e332b0e7e11ebeb83bdbfcd9e3e1600817a
[09/22] toradex: Include env.h to permit reading the environment
commit: bcf10f16ea41cd690be59a88d8e7292881d01e56
[10/22] advantech: Include env.h in imx8qm_dmsse20_a1
commit: 0f8a4a9c4427370c5f20b8ffcbd615fb9658921e
[11/22] tegra: Include env.h to permit reading the environment
commit: 433e86abea7e8b570ee0ad89842ac806511d1b94
[12/22] synology: Include env.h to permit reading the environment
commit: f24a197973ad0c5f473401b16a801794f2764678
[13/22] amlogic: Include env.h to permit reading the environment
commit: 6d9d6ba71ab9391e5fb163634bfb1cc65987cdd4
[14/22] freescale: Include env.h to permit reading the environment
commit: 2876ff79b257667438ae7a6132d5ce750ec501ac
[15/22] google: Include env.h to permit reading the environment
commit: 98faae1617b44e53c475adf8552245691e1f05fb
[16/22] liebherr: Include env.h to permit reading the environment
commit: ea9afef22d49a4ac12484e01fd459e225da790b7
[17/22] technexion: Include env.h to permit reading the environment
commit: 7b612cfa757a44d1bdee6d087e24e2e5c9d8a868
[18/22] net: Include byteorder in net6.h
commit: 22d4e22a3d2e8a95c37c0635701daaee8d5a5c6b
[19/22] net: Include env.h in pcap.c
commit: 85b013e3f43ff4fa50ced6a23ba336813eaf9320
[20/22] net: dc2114x: Include env.h to permit reading the environment
commit: 183d88cdfc19ea7bd56af69512f0d1425de73e77
[21/22] global: Avoid indirect inclusion of <env.h> from <net.h>
commit: ae9ff5ae6f579f321a1b695c82453b67ec1bf6db
[22/22] include/net.h: Drop <env.h>
commit: fe33175c073fe21945b39a4a8c27806cf0154bf3
--
Tom
