On Tue, 27 May 2025 at 16:00, Dhruva Gole <d-g...@ti.com> wrote:
>
> Hi Peter,
>
> On May 25, 2025 at 13:10:58 +0100, Peter Robinson wrote:
> > The details of the sysfw.itb from the R5 build that
> > also needs to be copied as part of the target images
> > is missing, but is included in the image formats a
> > little further down, so add it to the instructions.
> >
> > Signed-off-by: Peter Robinson <pbrobin...@gmail.com>
> > ---
> >  doc/board/beagle/j721e_beagleboneai64.rst | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/doc/board/beagle/j721e_beagleboneai64.rst 
> > b/doc/board/beagle/j721e_beagleboneai64.rst
> > index 090b2b3b86a..a57bc743569 100644
> > --- a/doc/board/beagle/j721e_beagleboneai64.rst
> > +++ b/doc/board/beagle/j721e_beagleboneai64.rst
> > @@ -83,6 +83,7 @@ Target Images
> >  Copy the below images to an SD card and boot:
> >
> >  * tiboot3-j721e-gp-evm.bin from R5 build as tiboot3.bin
> > +* sysfw-j721e-gp-evm.itb from R5 build as sysfw.itb
>
> Thanks for adding this, and I am okay with the changes.
>
> But also, does it make sense to make all of this inherit from a label that
> we can add inside [1] and include that here directly?
> I am okay if you just wanna label the gp part and include it here as
> well.

I'm guessing you're referring to doing something with markdown in this
context, I apologise but I am far from a markdown expert here, I think
possibly including it may make it less readable for those using a
terminal but I may have also completely missed your point here, maybe
that could be done as a follow up :)

> Either way,
> Reviewed-by: Dhruva Gole <d-g...@ti.com>
>
> [1] https://docs.u-boot.org/en/latest/board/ti/j721e_evm.html#target-images
>
>
>
> --
> Best regards,
> Dhruva Gole
> Texas Instruments Incorporated

Reply via email to