Re: [PATCH v2 2/4] scsi: Implement get_blk() function

[neil . armstrong]

On 06/05/2025 09:24, Varadarajan Narayanan wrote:

Add a function to obtain the block device for SCSI.

Signed-off-by: Varadarajan Narayanan <quic_var...@quicinc.com>
---
  drivers/scsi/scsi-uclass.c | 30 ++++++++++++++++++++++++++++++
  include/scsi.h             | 11 +++++++++++
  2 files changed, 41 insertions(+)

diff --git a/drivers/scsi/scsi-uclass.c b/drivers/scsi/scsi-uclass.c
index 1ee8236c05c..aa037c8e353 100644
--- a/drivers/scsi/scsi-uclass.c
+++ b/drivers/scsi/scsi-uclass.c
@@ -10,7 +10,9 @@

#define LOG_CATEGORY UCLASS_SCSI +#include <blk.h>

  #include <dm.h>
+#include <part.h>
  #include <scsi.h>

int scsi_exec(struct udevice *dev, struct scsi_cmd *pccb)

@@ -23,6 +25,34 @@ int scsi_exec(struct udevice *dev, struct scsi_cmd *pccb)
        return ops->exec(dev, pccb);
  }

+int scsi_get_blk(const char *uuid,

Here the parameter is uuid

+                struct blk_desc **blk_desc_ptr,
+                struct disk_partition *part_info_ptr)
+{
+       static int is_scsi_scanned;
+       struct blk_desc *blk;
+       int i, ret;
+
+       if (!is_scsi_scanned) {
+               scsi_scan(false /* no verbose */);
+               is_scsi_scanned = 1;
+       }
+
+       for (i = 0; i < blk_find_max_devnum(UCLASS_SCSI) + 1; i++) {
+               ret = blk_get_desc(UCLASS_SCSI, i, &blk);
+               if (ret)
+                       continue;
+
+               ret = part_get_info_by_uuid(blk, uuid, part_info_ptr);
+               if (ret > 0) {
+                       *blk_desc_ptr = blk;
+                       return 0;
+               }
+       }
+
+       return -1;
+}
+
  int scsi_bus_reset(struct udevice *dev)
  {
        struct scsi_ops *ops = scsi_get_ops(dev);
diff --git a/include/scsi.h b/include/scsi.h
index ab53b47b58f..d6b6e6b665f 100644
--- a/include/scsi.h
+++ b/include/scsi.h
@@ -351,6 +351,17 @@ int scsi_scan(bool verbose);
   */
  int scsi_scan_dev(struct udevice *dev, bool verbose);

+/**

+ * scsi_get_blk() - Provides SCSI partition information.
+ *
+ * @partition_name: Partition name for fetching its info
+ * @blk_desc_ptr:   Provides the blk descriptor
+ * @part_info_ptr:  Provides partition info
+ */
+int scsi_get_blk(const char *partition_name,
+                struct blk_desc **blk_desc_ptr,
+                struct disk_partition *part_info_ptr);

And here it's still partition_name, and the name should be scsi_get_blk_by_uuid 
in this case.

Neil

+
  #define SCSI_IDENTIFY                                 0xC0  /* not used */

/* Hardware errors */