On Sun, May 04, 2025 at 03:42:24PM -0700, Tony Dinh wrote: > On Sun, May 4, 2025 at 3:37 PM Tony Dinh <mibo...@gmail.com> wrote: > > > > Hi Tom, > > > > On Fri, May 2, 2025 at 1:12 PM Tom Rini <tr...@konsulko.com> wrote: > > > > > > This converts almost all of the remaining non-DM_SERIAL users to enable > > > DM_SERIAL. These are platforms where there have long been other SoC > > > boards that have switched and so it's been a matter of inertia keeping > > > these from being converted. Do so now. > > > > > > Signed-off-by: Tom Rini <tr...@konsulko.com> > > > > The Kirkwood boards (not sure about the others) also need to have > > CONFIG_SYS_NS16550 enabled after we removed CONFIG_SYS_NS16550_SERIAL > > and CONFIG_SYS_NS16550_REG_SIZE. > > > > Here was the patch: > > https://lists.denx.de/pipermail/u-boot/2023-January/507221.html > > > > [PATCH] arm: kirkwood: Use CONFIG_SYS_NS16550 with DM_SERIAL for Kirkwood > > boards > > arm: kirkwood: Use CONFIG_SYS_NS16550 with DM_SERIAL for Kirkwood boards > > CONFIG_SYS_NS16550 is required when DM_SERIAL is enabled for > > Kirkwood boards. > > > > diff --git a/arch/arm/mach-kirkwood/Kconfig b/arch/arm/mach-kirkwood/Kconfig > > index 45cc9326368..b19ed2c6b3e 100644 > > --- a/arch/arm/mach-kirkwood/Kconfig > > +++ b/arch/arm/mach-kirkwood/Kconfig > > @@ -15,6 +15,7 @@ config SHEEVA_88SV131 > > config KIRKWOOD_COMMON > > bool > > select DM_SERIAL > > + select SYS_NS16550 > > > > config HAS_CUSTOM_SYS_INIT_SP_ADDR > > bool "Use a custom location for the initial stack pointer address" > > > > So we need to either add SYS_NS16550 to each of these defconfigs > > below, or select KIRKWOOD_COMMON for each of these boards in > > arch/arm/mach-kirkwood/Kconfig: > > > > SBx81LIFKW_defconfig > > SBx81LIFXCAT_defconfig > > d2net_v2_defconfig > > dns325_defconfig > > guruplug_defconfig > > ib62x0_defconfig > > inetspace_v2_defconfig > > nas220_defconfig > > net2big_v2_defconfig > > netspace_lite_v2_defconfig > > netspace_max_v2_defconfig > > netspace_mini_v2_defconfig > > netspace_v2_defconfig
Ah OK, thanks. Can you please prepare a patch to select KIRKWOOD_COMMON for these? [snip] > BTW, I will submit a separate patch for the DS109. OK, great. -- Tom
signature.asc
Description: PGP signature
