Hi Simon, > > > This series collects together some new features for expo to make it more > > > useful for boot menus: > > > > > > - measurement and display of multi-line text objects > > > - internal alignment for objects (e.g. centred text) > > > - editable strings in text fields > > > - new 'box' object to draw a rectangle > > > - highlighting of menu items, rather than just relying on a pointer
Each of the 5 sections above should be a separate patch set. A patch set should be on a single topic, as soon as you feel you need to add the term "collects together" you should be splitting it up. > > > Expo's boot menu is restructured so that it is possible to iterate > > > through various bootdevs and update the menu as new ones are found. This > > > is more in keeping with how bootstd works. > > > > > > A new textedit object is added, intended to provide a simple text > > > editor. Future work will complete this. > > > > > > With this series the boot menu has a better layout and appearance. > > > > > > Changes in v2: > > > - Add new patch to pass in the video device for cedit_prepare() > > > - Add new patch to test rendering a lineedit > > > - Add new patch to test editing a lineedit > > > - Handle the case of an initially empty string > > > - Only check the text objects used by the bootmenu, for now > > > > ... include the 13 part series you asked me if could go in now, > > yesterday? > > > > > Simon Glass (60): > > > > 60 is far too much for anyone to provide meaningful review. > > This is expo and no one commented on the previous series, so I'm not > expecting much feedback. But once people start using it, things will > come up. Well a series of 6 patches just goes straight into the trash because I don't even know where to try and begin to test it. Peter
