> -----Original Message-----
> From: Meng, Tingting <tingting.m...@altera.com>
> Sent: Tuesday, April 29, 2025 5:56 PM
> To: u-boot@lists.denx.de
> Cc: Marek Vasut <ma...@denx.de>; Chee, Tien Fong
> <tien.fong.c...@altera.com>; Meng, Tingting <tingting.m...@altera.com>;
> Hea, Kok Kiang <kok.kiang....@altera.com>; Maniyam, Dinesh
> <dinesh.mani...@altera.com>; Ng, Boon Khai <boon.khai...@altera.com>;
> Yuslaimi, Alif Zakuan <alif.zakuan.yusla...@altera.com>; Rosdi, Danish
> Ahmad <danish.ahmad.ro...@altera.com>; Zamri, Muhammad Hazim Izzat
> <muhammad.hazim.izzat.za...@altera.com>; Lim, Jit Loon
> <jit.loon....@altera.com>
> Subject: [PATCH v1 1/1] arm: socfpga: agilex5: Coverity issue cleanup in
> jtag_usercode check
>
> From: Tingting Meng <tingting.m...@altera.com>
>
> A redundant comparison (jtag_usercode >= 0) was removed from the
> condition checking jtag_usercode. Since jtag_usercode is an unsigned integer,
> the check for non-negativity was always true. The code was simplified to
> resolve the Coverity warning.
>
> Signed-off-by: Tingting Meng <tingting.m...@altera.com>
> ---
> arch/arm/mach-socfpga/board.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-socfpga/board.c b/arch/arm/mach-
> socfpga/board.c index 8506d510413..8bec7c6dccd 100644
> --- a/arch/arm/mach-socfpga/board.c
> +++ b/arch/arm/mach-socfpga/board.c
> @@ -133,7 +133,7 @@ u8 socfpga_get_board_id(void)
>
> if (jtag_usercode == DEFAULT_JTAG_USERCODE) {
> debug("JTAG Usercode is not set. Default Board ID to 0\n");
> - } else if (jtag_usercode >= 0 && jtag_usercode <= 255) {
> + } else if (jtag_usercode <= 255) {
> board_id = jtag_usercode;
> debug("Valid JTAG Usercode. Set Board ID to %u\n",
> board_id);
> } else {
> --
> 2.25.1
Reviewed-by: Tien Fong Chee <tien.fong.c...@intel.com>
Best regards,
Tien Fong
