On Tue, Apr 29, 2025 at 06:30:42PM +0200, Quentin Schulz wrote: > Hi Chen-Yu, > > On 4/29/25 5:44 PM, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai <w...@csie.org> > > > > The rockchip_dw_mmc driver supports the MMC controller found in Rockchip > > SoCs. This controller is used for the SD card on all SoCs and eMMC on > > older SoCs. Almost all defconfigs for Rockchip platforms have this > > enabled. > > > > Enable it by default for all supported Rockchip SoCs. Disable it > > explicitly in defconfigs that previously didn't have it enabled. > > > > I'll let Tom confirm (or not), but I think it'd make sense to make this > patch lighter by not including the defconfig changes that would be simply > done automatically when doing a defconfig sync, e.g. like > bdf41fb7b386bdf60303b7a92431467c12779c86 did? This would be nice because it > would make your patch much easier to apply if they take long to be applied > (e.g. someone else changes the defconfig and now we have conflicts all over > the place). This also would remove unrelated changes from the diff, > specifically the ones for the PX30 boards which are just noise at this > point.
Yeah, if we have to v2 this, or just it's too hard to apply later, the automated parts of the defconfig changes can be omitted as it obscures any review needed on the defconfigs for manual changes. -- Tom
signature.asc
Description: PGP signature
