On 13:19-20250429, Udit Kumar wrote:
> On K3 devices two drivers ti_sci and ti_sci_dm are supporting firmware
> functions. At run time one of driver is used.
>
> Driver ti_sci already initializing head for dev_list in its probe
> function, but it was missed in ti_sci_dm driver.
>
> So add head list init support for ti_sci_dm driver.
>
> Fixes: 5d5a699855a7("firmware: ti_sci: Add support for Resoure Management at
> R5 SPL stage")
Nice catch.
>
> Signed-off-by: Udit Kumar <u-kum...@ti.com>
> ---
> drivers/firmware/ti_sci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 54d6689ce78..a599de9e013 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -2891,6 +2891,8 @@ static __maybe_unused int ti_sci_dm_probe(struct
> udevice *dev)
>
> list_add_tail(&info->list, &ti_sci_list);
>
> + INIT_LIST_HEAD(&info->dev_list);
> +
I don't think this impacts a lot, but for sanity reasons, you might
want to do this before we add it to ti_sci_list.
Similarly, ti_sci_probe() does INIT_LIST_HEAD after adding to the
&ti_sci_list, might want to do the INIT before adding to list.
> ops = &info->handle.ops;
>
> rm_core_ops = &ops->rm_core_ops;
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
