Hi I've got a question regarding arch-fs-layerscape and would be grateful if somebody could help me to get a better understanding of a few things before I submit a patch with some changes so that I won't make a mess on the mailing list with unnecessary changes.
1) Looking at the ls1028a_common.h - it defines CFG_SYS_DDR_BLOCK2_BASE as well as some other defines used by ls1028a-rdb and ls1028a-qds boards. Moreover ls1028a-rdb and ls1028a-qds defines (in board config files) that they use 2 DDR banks (CONFIG_NR_DRAM_BANKS=2) which is true as both of them use more than 2GB of RAM. However, what if the ls1028a based board uses only 2 GB of RAM? In my opinion, in this case, CONFIG_NR_DRAM_BANKS should be set to 1 and CFG_SYS_DDR_BLOCK2_BASE should not be defined at all, am I right? Is they any reason other than the possible compilation errors (CFG_SYS_DDR_BLOCK2_BASE is assumed to be defined always) that CFG_SYS_DDR_BLOCK2_BASE should be defined CONFIG_NR_DRAM_BANKS=2 even when the board uses only the first DDR region? 2) I've browsed through the code and it seems that there are some ifdefs on CONFIG_SYS_DDR_BLOCK3_BASE, whereas when the code refers to DDR BLOCK2 BASE it uses CFG_SYS_DDR_BLOCK2_BASE, like in the example above. Is CONFIG_SYS_DDR_BLOCK3_BASE a legacy name and should be changed to CFG_SYS_DDR_BLOCK3_BASE? This question is based on what I've found in doc/develop/system_configuration. Best regards Patryk
