Hi Miquel, On Fri, 18 Apr 2025 at 01:10, Miquel Raynal <miquel.ray...@bootlin.com> wrote: > > Hi Tom, > > On 17/04/2025 at 13:53:11 +02, Wadim Egorov <w.ego...@phytec.de> wrote: > > > Unfortunately this change breaks boot on K3 platform. > > U-Boot will hang after: > > > > U-Boot SPL 2025.04-01050-ga40fc5afaec0 (Apr 14 2025 - 07:31:32 +0000) > > SYSFW ABI: 3.1 (firmware rev 0x0009 '9.2.7--v09.02.07 (Kool Koala)') > > > > This reverts commit 197376fbf300e92afa0a1583815d9c9eb52d613a as > > suggested in [1]. > > > > [1] https://lists.denx.de/pipermail/u-boot/2025-April/587032.html > > > > Signed-off-by: Wadim Egorov <w.ego...@phytec.de> > > This sadly needs to get in, there have been 3 or 4 reports already, as > many boards are broken. We need to find another way to add refcounting > (otherwise some imx8* features will stay broken), but it requires more > thinking time. > > Acked-by: Miquel Raynal <miquel.ray...@bootlin.com>
We had this discussion on your patch and you ended up with a 'low-level' function to provide the base functionality. But it would be easier if you retained the current behaviour and then added ref-counting to two new functions. Then people can migrate. Of course, people perhaps won't migrate. This sort of thing is quite tricky. But I still think this would be an easier route. You could perhaps even add a Kconfig option like POWER_DOMAIN_NO_REF_COUNT which uses the current behaviour. Regards, Simon
