On Wed, Apr 16, 2025 at 02:38:00PM +0200, Mattijs Korpershoek wrote: > On mer., avril 16, 2025 at 10:25, Mattijs Korpershoek > <mkorpersh...@kernel.org> wrote: > > > Hi Tom, > > > > On mar., avril 15, 2025 at 11:59, Tom Rini <tr...@konsulko.com> wrote: > > > >> On Wed, Apr 09, 2025 at 09:46:34AM +0200, Mattijs Korpershoek wrote: > >> > >>> Recent Ubuntu versions (24.04+) disallow pip by default when > >>> installing packages. The recommended approach is to use a virtualenv > >>> instead. > >>> Because of this, "make pip" is failing on such versions. > >>> > >>> To prepare CI container migration to Ubuntu 24.04, use a virtualenv > >>> in the make_pip script. > >>> > >>> Note: This has been reported on [1] > >>> > >>> [1] https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/37 > >>> > >>> Signed-off-by: Mattijs Korpershoek <mkorpersh...@kernel.org> > >>> Reviewed-by: Tom Rini <tr...@konsulko.com> > >>> --- > >>> This has been tested in docker on ubuntu:24.04 after running: > >>> $ apt install python3 python3-virtualenv > >>> > >>> with: > >>> $ ./scripts/make_pip.sh u_boot_pylib "-n" > >>> > >>> And shows: > >>> Successfully built u_boot_pylib-0.0.6.tar.gz and > >>> u_boot_pylib-0.0.6-py3-none-any.whl > >>> > >>> Also tested with "$ make pip". > >>> --- > >>> scripts/make_pip.sh | 6 ++++++ > >>> 1 file changed, 6 insertions(+) > >> > >> So, this ends up failing with Ubuntu 22.04 thusly: > >> https://source.denx.de/u-boot/u-boot/-/jobs/1103567 > > > > Argh, sorry I did not test that. > > > >> > >> And in short, I think your original plan to use venv not virtualenv is > >> correct, sorry for the noise. I'll post something to install > >> python3-venv to our container shortly and switch to venv not virtualenv > >> as that seems to be the long term best answer. > > > > Ok, will send a v2 to use venv instead. > > Posted here: > https://lore.kernel.org/all/87ikn44io3....@kernel.org/ > > As mentioned in the cover letter, this requires python3-venv to be added > in the container and I've assumed you will be doing that, Tom.
Yup, thanks again! -- Tom
signature.asc
Description: PGP signature
