Re: [PATCH] board: rockchip: Add LCKFB TaishanPi RK3566 Board

[Jiehui He]

Hi&nbsp;Jonas,<br/><br/>Thanks&nbsp;for&nbsp;your&nbsp;review&nbsp;and&nbsp;helpful&nbsp;suggestions!<br/><br/>On&nbsp;2025-03-30&nbsp;19:27,&nbsp;Jonas&nbsp;Karlman&nbsp;wrote:<br/>&gt;&gt;&nbsp;diff&nbsp;--git&nbsp;a/configs/lckfb-tspi-rk3566_defconfig&nbsp;b/configs/lckfb-tspi-rk3566_defconfig<br/>&gt;&gt;&nbsp;new&nbsp;file&nbsp;mode&nbsp;100644<br/>&gt;&gt;&nbsp;index&nbsp;00000000..126ede37<br/>&gt;&gt;&nbsp;---&nbsp;/dev/null<br/>&gt;&gt;&nbsp;+++&nbsp;b/configs/lckfb-tspi-rk3566_defconfig<br/>&gt;&gt;&nbsp;@@&nbsp;-0,0&nbsp;+1,84&nbsp;@@<br/>&gt;&gt;&nbsp;+CONFIG_ARM=y<br/>&gt;&gt;&nbsp;+CONFIG_SKIP_LOWLEVEL_INIT=y<br/>&gt;&gt;&nbsp;+CONFIG_COUNTER_FREQUENCY=24000000<br/>&gt;&gt;&nbsp;+CONFIG_ARCH_ROCKCHIP=y<br/>&gt;&gt;&nbsp;+CONFIG_SPL_GPIO=y<br/><br/>&gt;&nbsp;The&nbsp;SPL&nbsp;control&nbsp;FDT&nbsp;is&nbsp;not&nbsp;including&nbsp;any&nbsp;gpio&nbsp;related&nbsp;nodes,&nbsp;this&nbsp;could<br/>&gt;&nbsp;be&nbsp;dropped.<br/><br/>Ack.&nbsp;I&nbsp;will&nbsp;remove&nbsp;`CONFIG_SPL_GPIO`.<br/><br/>&gt;&gt;&nbsp;...<br/>&gt;&gt;&nbsp;+CONFIG_SPL_POWER=y<br/><br/>&gt;&nbsp;The&nbsp;SPL&nbsp;control&nbsp;FDT&nbsp;is&nbsp;not&nbsp;including&nbsp;any&nbsp;power&nbsp;related&nbsp;nodes,&nbsp;this&nbsp;could<br/>&gt;&nbsp;be&nbsp;dropped.<br/><br/>Will&nbsp;drop&nbsp;`CONFIG_SPL_POWER`.<br/><br/>&gt;&gt;&nbsp;...<br/>&gt;&gt;&nbsp;+CONFIG_DWC_ETH_QOS=y<br/>&gt;&gt;&nbsp;+CONFIG_DWC_ETH_QOS_ROCKCHIP=y<br/><br/>&gt;&nbsp;It&nbsp;does&nbsp;not&nbsp;look&nbsp;like&nbsp;the&nbsp;device&nbsp;tree&nbsp;enable&nbsp;any&nbsp;Ethernet&nbsp;devices,&nbsp;these<br/>&gt;&nbsp;two&nbsp;could&nbsp;be&nbsp;dropped.<br/><br/>I’ll&nbsp;remove&nbsp;both&nbsp;`CONFIG_DWC_ETH_QOS`&nbsp;and&nbsp;`CONFIG_DWC_ETH_QOS_ROCKCHIP`.<br/><br/>&gt;&gt;&nbsp;...<br/>&gt;&gt;&nbsp;+CONFIG_SPL_DM_REGULATOR=y<br/>&gt;&gt;&nbsp;+CONFIG_SPL_DM_REGULATOR_FIXED=y<br/><br/>&gt;&nbsp;The&nbsp;SPL&nbsp;control&nbsp;FDT&nbsp;is&nbsp;not&nbsp;including&nbsp;any&nbsp;fixed&nbsp;regulators,&nbsp;these&nbsp;two<br/>&gt;&nbsp;could&nbsp;be&nbsp;dropped.<br/><br/>I&nbsp;will&nbsp;remove&nbsp;`CONFIG_SPL_DM_REGULATOR`&nbsp;and&nbsp;`CONFIG_SPL_DM_REGULATOR_FIXED`.<br/><br/>&gt;&gt;&nbsp;...<br/>&gt;&gt;&nbsp;diff&nbsp;--git&nbsp;a/doc/board/rockchip/rockchip.rst&nbsp;b/doc/board/rockchip/rockchip.rst<br/>&gt;&gt;&nbsp;index&nbsp;1407080f..ae9a8c8a&nbsp;100644<br/>&gt;&gt;&nbsp;---&nbsp;a/doc/board/rockchip/rockchip.rst<br/>&gt;&gt;&nbsp;+++&nbsp;b/doc/board/rockchip/rockchip.rst<br/>&gt;&gt;&nbsp;@@&nbsp;-112,6&nbsp;+112,7&nbsp;@@&nbsp;List&nbsp;of&nbsp;mainline&nbsp;supported&nbsp;Rockchip&nbsp;boards:<br/>&gt;&gt;&nbsp;-&nbsp;Radxa&nbsp;ROCK&nbsp;3C&nbsp;(rock-3c-rk3566)<br/>&gt;&gt;&nbsp;-&nbsp;Radxa&nbsp;ZERO&nbsp;3W/3E&nbsp;(radxa-zero-3-rk3566)<br/>&gt;&gt;&nbsp;-&nbsp;Xunlong&nbsp;Orange&nbsp;Pi&nbsp;3B&nbsp;(orangepi-3b-rk3566)<br/>&gt;&gt;&nbsp;+&nbsp;-&nbsp;LCKFB&nbsp;TaishanPi&nbsp;(lckfb-tspi-rk3566)<br/><br/>&gt;&nbsp;Please&nbsp;add&nbsp;this&nbsp;line&nbsp;in&nbsp;correct&nbsp;alphabetical&nbsp;order&nbsp;and&nbsp;not&nbsp;at&nbsp;the&nbsp;bottom.<br/><br/>Thanks!&nbsp;I’ll&nbsp;fix&nbsp;the&nbsp;order&nbsp;and&nbsp;place&nbsp;it&nbsp;alphabetically&nbsp;in&nbsp;the&nbsp;next&nbsp;revision.<br/><br/>Best&nbsp;regards,&nbsp;&nbsp;<br/>Jiehui<br/>