> -----Original Message-----
> From: Tom Rini <tr...@konsulko.com>
> Sent: Tuesday, 8 April 2025 10:27 pm
> To: Maniyam, Dinesh <dinesh.mani...@altera.com>
> Cc: u-boot@lists.denx.de; Marek <ma...@denx.de>; Simon
> <simon.k.r.goldschm...@gmail.com>; Simon Glass <s...@chromium.org>; Dario
> Binacchi <dario.binac...@amarulasolutions.com>; Ilias Apalodimas
> <ilias.apalodi...@linaro.org>; Heinrich Schuchardt <xypron.g...@gmx.de>;
> Jerome Forissier <jerome.foriss...@linaro.org>; Mattijs Korpershoek
> <mkorpersh...@baylibre.com>; Ibai Erkiaga <ibai.erkiaga-elo...@amd.com>;
> Michal Simek <michal.si...@amd.com>; Dmitry Rokosov
> <ddroko...@salutedevices.com>; Jonas Karlman <jo...@kwiboo.se>; Sebastian
> Reichel <sebastian.reic...@collabora.com>; Meng, Tingting
> <tingting.m...@altera.com>; Chee, Tien Fong <tien.fong.c...@altera.com>;
> Hea, Kok Kiang <kok.kiang....@altera.com>; Ng, Boon Khai
> <boon.khai...@altera.com>; Yuslaimi, Alif Zakuan
> <alif.zakuan.yusla...@altera.com>; Zamri, Muhammad Hazim Izzat
> <muhammad.hazim.izzat.za...@altera.com>; Lim, Jit Loon
> <jit.loon....@altera.com>; Tang, Sieu Mun <sieu.mun.t...@altera.com>
> Subject: Re: [resend v3 00/12] Add Synopsys MIPI I3C Driver support
>
> On Tue, Apr 08, 2025 at 08:14:46AM +0000, Maniyam, Dinesh wrote:
>
> > Hi Tom Rini,
> >
> > > -----Original Message-----
> > > From: Maniyam, Dinesh
> > > Sent: Monday, 24 March 2025 4:40 pm
> > > To: u-boot@lists.denx.de
> > > Cc: Marek <ma...@denx.de>; Simon <simon.k.r.goldschm...@gmail.com>;
> > > Simon Glass <s...@chromium.org>; Tom Rini <tr...@konsulko.com>; Dario
> > > Binacchi <dario.binac...@amarulasolutions.com>; Ilias Apalodimas
> > > <ilias.apalodi...@linaro.org>; Heinrich Schuchardt
> > > <xypron.g...@gmx.de>; Jerome Forissier
> > > <jerome.foriss...@linaro.org>; Mattijs Korpershoek
> > > <mkorpersh...@baylibre.com>; Ibai Erkiaga
> > > <ibai.erkiaga-elo...@amd.com>; Michal Simek <michal.si...@amd.com>;
> > > Dmitry Rokosov <ddroko...@salutedevices.com>; Jonas Karlman
> > > <jo...@kwiboo.se>; Sebastian Reichel
> > > <sebastian.reic...@collabora.com>; Meng, Tingting
> > > <tingting.m...@altera.com>; Chee, Tien Fong
> > > <tien.fong.c...@altera.com>; Hea, Kok Kiang
> > > <kok.kiang....@altera.com>; Maniyam, Dinesh
> > > <dinesh.mani...@altera.com>; Ng, Boon Khai
> > > <boon.khai...@altera.com>; Yuslaimi, Alif Zakuan
> > > <alif.zakuan.yusla...@altera.com>; Zamri, Muhammad Hazim Izzat
> > > <muhammad.hazim.izzat.za...@altera.com>; Lim, Jit Loon
> > > <jit.loon....@altera.com>; Tang, Sieu Mun <sieu.mun.t...@altera.com>
> > > Subject: [resend v3 00/12] Add Synopsys MIPI I3C Driver support
> > >
> > > From: Dinesh Maniyam <dinesh.mani...@altera.com>
> > >
> > > This patchset add Synopsys MIPI I3C Driver support for Intel Agilex5
> > > devices.
> > >
> > > The i3c driver is leveraged from the master/dw-i3c-master.c,
> > > i3c/device.c and i3c/master.c Linux version 6.6.37 LTS And few
> > > header files included to be part of the migration; i3c/internals.h,
> > > include/linux/i3c/ccc.h, include/linux/i3c/device.h and
> include/linux/i3c/master.h.
> > > Additional i3c uclass driver and command files added to support i3c
> > > read and write in U-Boot.
> > >
> > > Patch status:
> > >
> > > Detail changelog can find in commit message.
> > >
> > > v3->v2:
> > > --------
> > > - Squash commit 10 to commit 9
> > > - Resolve index for new files to pass the checkpatch
> > >
> > > Commit: sandbox_defconfig: Enable configs for sandbox i3c
> > > Commit: agilex5_defconfig: Enable i3c configs for agilex5
> > > - use savedefconfig
> > >
> > > drivers: Enabled Kconfig and Makefile for i3c support
> > > - Add maintainer for i3c
> > >
> > > drivers: i3c: Enabled Kconfig and Makefile for DWI3C
> > > - Add empty lines for if/endif
> > >
> > > drivers: i3c: Add i3c sandbox simple test.
> > > - Removed DECLARE_GLOBAL_DATA_PTR
> > >
> > > v1->v2:
> > > --------
> > > Reorder commits.
> > >
> > > Added commits:
> > > - drivers: i3c: Add i3c sandbox simple test.
> > > - test: cmd: Add simple test for i3c
> > > - configs: sandbox_defconfig: Enable configs for sandbox i3c
> > > - configs: agilex5_defconfig: Enable i3c configs for agilex5
> > >
> > > History:
> > > --------
> > > [v1]:
> > > https://patchwork.ozlabs.org/project/uboot/cover/20250218025705.5005
> > > 1-1-
> > > dinesh.mani...@intel.com/
> > > [v2]:
> > > https://patchwork.ozlabs.org/project/uboot/cover/20250314040902.4362
> > > 1-1-
> > > dinesh.mani...@altera.com/
> > >
> > > Dinesh Maniyam (12):
> > > drivers: i3c: Add new i3c uclass id
> > > drivers: i3c: Add driver for MIPI DWI3C
> > > drivers: i3c: Add i3c uclass driver.
> > > drivers: Enabled Kconfig and Makefile for i3c support
> > > drivers: i3c: Enabled Kconfig and Makefile for DWI3C
> > > drivers: i3c: Add i3c sandbox simple test.
> > > drivers: i3c: master: Enable probe i3c without slave device
> > > i3c: master: dw-i3c-master: Fix OD_TIMING for spike filter
> > > cmd: Add i3c command support.
> > > test: cmd: Add simple test for i3c
> > > configs: sandbox_defconfig: Enable configs for sandbox i3c
> > > configs: agilex5_defconfig: Enable i3c configs for agilex5
> > >
> > > MAINTAINERS | 7 +
> > > arch/sandbox/dts/test.dts | 8 +
> > > cmd/Kconfig | 6 +
> > > cmd/Makefile | 1 +
> > > cmd/i3c.c | 193 +++
> > > configs/sandbox_defconfig | 4 +
> > > configs/socfpga_agilex5_defconfig | 3 +
> > > doc/usage/cmd/i3c.rst | 98 ++
> > > drivers/Kconfig | 2 +
> > > drivers/Makefile | 1 +
> > > drivers/i3c/Kconfig | 27 +
> > > drivers/i3c/Makefile | 5 +
> > > drivers/i3c/device.c | 262 ++++
> > > drivers/i3c/i3c-uclass.c | 38 +
> > > drivers/i3c/internals.h | 26 +
> > > drivers/i3c/master.c | 2072 ++++++++++++++++++++++++++++
> > > drivers/i3c/master/Kconfig | 11 +
> > > drivers/i3c/master/Makefile | 3 +
> > > drivers/i3c/master/dw-i3c-master.c | 1058 ++++++++++++++
> > > drivers/i3c/sandbox_i3c.c | 56 +
> > > include/dm/device.h | 2 +
> > > include/dm/uclass-id.h | 1 +
> > > include/dw-i3c.h | 252 ++++
> > > include/i3c.h | 67 +
> > > include/linux/i3c/ccc.h | 385 ++++++
> > > include/linux/i3c/device.h | 286 ++++
> > > include/linux/i3c/master.h | 698 ++++++++++
> > > test/cmd/Makefile | 1 +
> > > test/cmd/i3c.c | 52 +
> > > test/dm/Makefile | 1 +
> > > test/dm/i3c.c | 34 +
> > > 31 files changed, 5660 insertions(+) create mode 100644 cmd/i3c.c
> > > create mode 100644 doc/usage/cmd/i3c.rst create mode 100644
> > > drivers/i3c/Kconfig create mode 100644 drivers/i3c/Makefile create
> > > mode
> > > 100644 drivers/i3c/device.c create mode 100644
> > > drivers/i3c/i3c-uclass.c create mode 100644 drivers/i3c/internals.h
> > > create mode 100644 drivers/i3c/master.c create mode 100644
> > > drivers/i3c/master/Kconfig create mode 100644
> > > drivers/i3c/master/Makefile create mode 100644
> > > drivers/i3c/master/dw-i3c- master.c create mode 100644
> > > drivers/i3c/sandbox_i3c.c create mode 100644 include/dw-i3c.h
> > > create mode 100644 include/i3c.h create mode 100644
> > > include/linux/i3c/ccc.h create mode 100644
> > > include/linux/i3c/device.h create mode 100644
> > > include/linux/i3c/master.h create mode 100644 test/cmd/i3c.c create
> > > mode 100644 test/dm/i3c.c
> > >
> > > --
> > > 2.26.2
> >
> > Please help to review the v3 of the patches.
> > Thanks for your time.
>
> Please run this through CI, see
> https://docs.u-boot.org/en/latest/develop/ci_testing.html, as there are both
> easy and less-easy doc failures, and then compile warnings:
> https://source.denx.de/u-boot/u-boot/-/jobs/1092473
>
> --
> Tom
https://github.com/u-boot/u-boot
Cloned the repo, tried to create and push a PR with the solution.
Thought, CI test will be triggered automatically once push the PR.
Since I'm not a maintainer I don't have the write access to push the PR.
Can I have access to push a PR just to trigger the CI test so that I can see
the result?
Or any other way to do it?
Dinesh
