Re: [PATCH v2 5/6] rockchip: Move imply ROCKCHIP_EXTERNAL_TPL under SoC Kconfig symbol

[Kever Yang]

On 2025/2/21 05:56, Jonas Karlman wrote:

New Rockchip SoCs will typically require use or an external TPL when
support for the SoC is added to U-Boot.

Move imply ROCKCHIP_EXTERNAL_TPL under SoC Kconfig symbol to remove a
future likelihood of a long "default y if" line.

Signed-off-by: Jonas Karlman <jo...@kwiboo.se>

Reviewed-by: Kever Yang <kever.y...@rock-chips.com>

Thanks,
- Kever

---
v2: No change
---
  arch/arm/mach-rockchip/Kconfig | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 7d867173fa1d..4a0faba9a67d 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -179,6 +179,7 @@ config ROCKCHIP_RK3308
        imply RNG_ROCKCHIP
        imply ROCKCHIP_COMMON_BOARD
        imply ROCKCHIP_COMMON_STACK_ADDR
+       imply ROCKCHIP_EXTERNAL_TPL
        imply ROCKCHIP_OTP
        imply SPL_CLK
        imply SPL_DM_SEQ_ALIAS
@@ -341,6 +342,7 @@ config ROCKCHIP_RK3568
        imply RNG_ROCKCHIP
        imply ROCKCHIP_COMMON_BOARD
        imply ROCKCHIP_COMMON_STACK_ADDR
+       imply ROCKCHIP_EXTERNAL_TPL
        imply ROCKCHIP_OTP
        imply SPL_ATF_NO_PLATFORM_PARAM if SPL_ATF
        imply SPL_MMC_HS200_SUPPORT if SPL_MMC && MMC_HS200_SUPPORT
@@ -375,6 +377,7 @@ config ROCKCHIP_RK3588
        imply RNG_ROCKCHIP
        imply ROCKCHIP_COMMON_BOARD
        imply ROCKCHIP_COMMON_STACK_ADDR
+       imply ROCKCHIP_EXTERNAL_TPL
        imply ROCKCHIP_OTP
        imply SCMI_FIRMWARE
        imply SPL_ATF_NO_PLATFORM_PARAM if SPL_ATF
@@ -501,7 +504,6 @@ config TPL_ROCKCHIP_COMMON_BOARD

config ROCKCHIP_EXTERNAL_TPL

        bool "Use external TPL binary"
-       default y if ROCKCHIP_RK3308 || ROCKCHIP_RK3568 || ROCKCHIP_RK3588
        help
          Some Rockchip SoCs require an external TPL to initialize DRAM.
          Enable this option and build with ROCKCHIP_TPL=/path/to/ddr.bin to