Dear Simon Glass,
In message <1306973675-8411-1-git-send-email-...@chromium.org> you wrote:
> This patch series adds bitfield operations to the Tegra code and modifies the
> existing code to use them. These operations are highly desirable for many
> reasons which I attempt to explain here.
They may appear desirable for you, but after carefully reading this
code again, and another time, I still have no doubts that I should
reject this code.
There are two big issues with it:
- It is non-standard. I don't see in which way this code would be an
improvement over the existing standard macros we already have.
- It is unportable (being based on the notion of bit numbers and bit
fields which are both compiler and architecture dependent).
In a previous message I already rejected patch no. 1 of this series; I
understand the other ones depend on that code, so please consider them
rejected, too.
Please use the existing standard macros instead.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A man either lives life as it happens to him, meets it head-on and
licks it, or he turns his back on it and starts to wither away.
-- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknown
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
